Comments (4)
I think the Gamecontroller Method might be better in a GameModel class, but this could be done after the build 1.
from risk-game.
Actually I'm not sure anymore lol. The teacher answered to my question that if the controller updates the view then it is not MVC, but on the slide 7 of MVC slides:
"the controller may also be responsible for updating the view"
from risk-game.
So I came to the teacher to ask a more precise question, he said that wether this can be considered as MVC or not is subject to debate, some people might say yes, others might say no. He also said he will not remove marks about that.
So in the end I dont think we need to make this for the build1, we could do it in the build2 since we will have to implement the observer pattern anyway.
from risk-game.
Done by hantoine. To be merged
from risk-game.
Related Issues (20)
- Refactor: Move fortification move handling to model
- Refactor: Remove Redundancy in initializePlayersArmies
- Refactor: armiesAssignation
- Refactor: Refactoring map file reading with exceptions HOT 1
- In view make sure the user cannot make invalid moves
- Display more information about attack move in phaseview HOT 1
- Refactor: create defend method in player HOT 1
- Make sure to save the tournament mode also HOT 1
- Refactor: MapFileManagement.createBoard
- Check current player is human before saving game HOT 1
- TODO after having merge : when loading saved game HOT 1
- BUG: in tournament mode no winning log message HOT 1
- Refactor: AttackMove.battle
- RiskModel:290 commented line
- TestAll test suite does not contain all the test classes HOT 1
- Refactor: Split MapEditorController.loadMapFromFile
- Tournament mode and saving/loading tests HOT 2
- RiskView window sometime does not have correct size HOT 2
- The RiskView slow down when the number of armies is high HOT 1
- Demonstration github: issues with code
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from risk-game.