Hello, flickraw cannot use Japanese, maybe after this change. <a

Thanks, I tried it, then... ruby1.9.3 -> ok ruby1.8.7 -&g

I modified oauth.rb. It seems to work well. Before: <div class="

I have commited it on <a class="commit-link" data-hovercard-type="commit" data-hoverca

OAuthClient::escape problem about flickraw HOT 4 CLOSED

hanklords commented on August 17, 2024

OAuthClient::escape problem

from flickraw.

Comments (4)

hanklords commented on August 17, 2024

Hello kinumi,

I believe this is an encoding bug. Can you try the commit 2133762 I just pushed and tell me if it works ?

Thanks,
Mael

from flickraw.

kinumi commented on August 17, 2024

Thanks,

I tried it, then...
ruby1.9.3 -> ok
ruby1.8.7 -> ng (and I want to use 1.8.7!)

Test Code:
("現像" is "\xE7\x8F\xBE\xE5\x83\x8F" in utf8)

#!ruby -Ku

require "rubygems"
require "uri"
require "./flickraw/lib/flickraw"

str = "現像"
puts "#{str} should be escaped to [#{URI.escape(str)}]"
puts "#{str} is escaped to [#{FlickRaw::OAuthClient.escape(str)}]"

Result:

$ rvm use 1.9.3
$ ruby -I ./flickraw/lib/ flickr.rb
現像 should be escaped to [%E7%8F%BE%E5%83%8F]
現像 is escaped to [%E7%8F%BE%E5%83%8F]
$ rvm use 1.8.7
$ ruby -I ./flickraw/lib/ flickr.rb
現像 should be escaped to [%E7%8F%BE%E5%83%8F]
現像 is escaped to [%E7%E5]

from flickraw.

kinumi commented on August 17, 2024

I modified oauth.rb. It seems to work well.

Before:

      def escape(s)
        encode_value(s).gsub(/[^a-zA-Z0-9\-\.\_\~]/) {
          sprintf("%%%02X", $&.unpack("C")[0])
        }
      end

After:

      def escape(s)
        encode_value(s).gsub(/[^a-zA-Z0-9\-\.\_\~]/) {
          $&.unpack("C*").map{|i| sprintf("%%%02X", i) }.join
        }
      end