Naming confusion about model HOT 3 CLOSED

@jeremyf Thanks for opening this discussion.

I'd stick with collection in mapper. It's part of the public API and it's a reasonable name for a "group of cohesive records". It has to be data store independent, for this reason I haven't named it table, because it's tight to the SQL world. That name was inspired by MongoDB concept of collection, that probably makes sense for other databases too: SQL, Redis..

Now, for the other internal naming, I'm open to suggestions. What do you think?

from model.

@jodosha In reading through the class, it has two types of methods:

• Configuration: :attribute, :entity, :repository, :identity, etc.
• Transformations: :serialize, :deserialize, :deserialize_attribute

# A collection is a set of homogeneous records. Think of a table of a SQL
# database or about collection of MongoDB.

I found this a bit misleading. The class appears to be instructions on how to map a homogenous set of persisted records from one form to another; Typically from persistence to memory and vice versa.

So perhaps the class might be better named Mapping::Instruction? I'm glad that you pointed out that that Lotus::Model::Mapper#collection is part of the public API. And I would like the method names to line up with class names.

So this leads to a question about deprecation notices. This does not mean I expect #collection to be deprecated. But instead want to know of methodology for deprecation notices. I assume this would be something in Lotus::Utils.

from model.

Closed by 9e32a30

from model.