Comments (5)
I agree that the adapters should be interchangeable, could you write up some example queries that currently don't work?
from model.
@viking I don't agree for a simple reason: an adapter should expose query DSL that's pertinent to the database that it targets.
My initial idea of Lotus::Model, was to ship it without adapters and have separated gem for each of them: eg lotus-model-sql
. But for the sake of convenience I decided to bundle it in the main library, alongside with the memory adapter.
This last guy supposed to mimic an in-memory key-value store. But because of the (partial) interchangeability, I decided to add a (partial) SQL query interface. It offers a decent and agnostic starting point for your application, without worrying too much about persistence.
My opinion is that if you find yourself to think about joins you already made your persistence decision: SQL instead of NoSQL or BigTable. At that point, it doesn't make sense to stay on the memory adapter, but have a concrete database.
Lotus offers a good level of abstraction, that allows you to test your objects in isolation. If you're worried about CI build times, you should be able to hit the database only when needed.
As final point, interchangeability means that all the adapters should expose an universal, omni-comprehensive query language across (No)SQL databases. Shall a Redis adapter be able to do map-reduce?
from model.
I agree that it's impractical to have perfect interchangeability. However, I think some small changes could be made to provide better minimal interchangeability. Fixing the where
method for the memory adapter to use all?
instead of any?
, for example.
I hadn't gotten to joins in my development before I realized that I had to stop using the memory adapter.
Perhaps there could be a very small set of methods that are expected to behave the same way across all adapters.
from model.
@viking 👍 for those small fixes. would you like to care? Thanks!
from model.
I'll work on it.
from model.
Related Issues (20)
- Date with BC note in PostgreSQL parsed incorrectly
- Optimistic Locking HOT 2
- Repository #find_or_create_by HOT 2
- Database column defaults are not replacing empty string or nil values HOT 4
- Sqlite3 'dumps database schema.sql' test failing HOT 3
- Private method 'Array' in hanami entity HOT 2
- Extra query with assoc and that make app slow HOT 1
- Associations don't seem to work well with as: aliases. HOT 3
- What's the recommend way to use transactions? HOT 3
- NoMethodError: undefined method `one' for #<Hanami::Model::Associations::HasMany> HOT 4
- BigDecimal.new error with Postgres HOT 16
- Can't prepare testing PostgreSQL database HOT 5
- #to_hash and implicit conversion HOT 4
- Error
- db prepare raises Postgres createdb error HOT 14
- Unable to control production DB log HOT 1
- [QUESTION] There is a "How to" guide for the test/development process? HOT 2
- Use original error in case role is missing for Postgres HOT 1
- Change default dataset configured in ROM HOT 1
- Outdated dependencies HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from model.