Comments (5)
I was researching this issue with the example proposed by @jodosha in #134
I was trying to set the default value if the value from database is nil and default isn't nil in https://github.com/lotus/model/blob/master/lib/lotus/model/mapping/coercer.rb#L69 but the "compilation" with this issue turn me on crazy.
an example:
in the from_record method, record is a hash
{id: 1, name: 'Luca', admin: nil}
and then a Hash is constructed in the line before commented, with the values coerced and used to build a new entity.
Do you think it's useful something like this?
from model.
There's a bigger problem here: imagine that the admin column in the example above is non-NULLable in addition to having a default set. Currently, if you don't explicitly set the value in the entity then Lotus sends column => nil
on serialisation. This causes Postgres, at least, to choke and error - you can't explicitly set a non-nullable value to null.
It also suggests that we're explicitly setting columns with default values to null when we might expect them to use the column default
from model.
$ LOTUS_ENV=test bundle exec lotus db prepare
Unsupported ruby class used as database type: Boolean (Sequel::Error)
How did you define the Sequel's TrueClass
FalseClass
?
from model.
@theCrab We use Sequel as migration engine. The list of Ruby types is defined here: http://lotusrb.org/guides/migrations/create-table/ 😸
from model.
Closing this for now, as we want to narrow the scope as much as possible before to hit 1.0.
from model.
Related Issues (20)
- Date with BC note in PostgreSQL parsed incorrectly
- Optimistic Locking HOT 2
- Repository #find_or_create_by HOT 2
- Database column defaults are not replacing empty string or nil values HOT 4
- Sqlite3 'dumps database schema.sql' test failing HOT 3
- Private method 'Array' in hanami entity HOT 2
- Extra query with assoc and that make app slow HOT 1
- Associations don't seem to work well with as: aliases. HOT 3
- What's the recommend way to use transactions? HOT 3
- NoMethodError: undefined method `one' for #<Hanami::Model::Associations::HasMany> HOT 4
- BigDecimal.new error with Postgres HOT 16
- Can't prepare testing PostgreSQL database HOT 5
- #to_hash and implicit conversion HOT 4
- Error
- db prepare raises Postgres createdb error HOT 14
- Unable to control production DB log HOT 1
- [QUESTION] There is a "How to" guide for the test/development process? HOT 2
- Use original error in case role is missing for Postgres HOT 1
- Change default dataset configured in ROM HOT 1
- Outdated dependencies HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from model.