Various issues with 'Getting started' guide about hanami.github.io HOT 7 CLOSED

@tragiclifestories thanks for filing this issue. I agree that the Getting Started Guide should be more consistent regarding the test framework choice. IMO I would opt for minitest instead of RSpec because of its being bundled with Ruby.

from hanami.github.io.

Yes, especially as that's what hanami new gives you without further specification. I personally prefer the RSpec-style assertions, but at the end of the day it's all just different ways to throw an error if something is false.

from hanami.github.io.

Thanks for submitting this @tragiclifestories!

The Getting Started guide actually is using Minitest 😄

It's just using the 'spec' syntax, rather than the normal syntax.

from hanami.github.io.

D'oh! And that's how long it's been since I used minitest ... Obviously happy for this to be closed since it was my own blunder and confusion.

from hanami.github.io.

I vote for spec style minitest for every test examples in Getting Started guide. Should we do it?

cc @AlfonsoUceda @jodosha

from hanami.github.io.

@joneslee85 The only ones I see that use assert are feature specs, but it looks like we'd need to add capybara_minitest_spec to change those over.

from hanami.github.io.

@tragiclifestories No worries about the confusion. We're happy that you opened this ticket anyway. Sync guides with actual implementation is hard. Better to check from time to time. 😉

@joneslee85 @cllns The "Getting Started" guide targets the most possible "vanilla" version of a Hanami project. Moving to RSpec like syntax for MiniTest or capybara_minitest_spec, requires that people following the guide to install these extra gems.

from hanami.github.io.