Code Monkey home page Code Monkey logo

Comments (4)

jesade-vbg avatar jesade-vbg commented on July 21, 2024

image

from hajk.

jacobwod avatar jacobwod commented on July 21, 2024

To be honest, I'm not sure. It feels like the possible outcome of a getMap request and the structure of the userDetails object will differ a lot between implementations. E.g. here's how it looks on one AD setup:

image

Perhaps we should come up with a common interface for this object?

from hajk.

jacobwod avatar jacobwod commented on July 21, 2024

One thing that comes into mind: if you active to show the button with user initials, what does it say in your setup?

Skärmavbild 2024-06-26 kl  10 49 36

I'm wondering because I notice that I'm utilising the displayName field, as well as the description field, both of which are lacking in your screenshot. Instead you have some fields that I haven't seen before.

As stated previously, I think we should agree upon some interface for userDetails. Perhaps sAMAccountName, mail, displayName and description should always be available?

from hajk.

jesade-vbg avatar jesade-vbg commented on July 21, 2024

Actually I have never seen the "button with user initials".

Well, that would be nice. But it would mean even more changes to NodeHoster and even more data will be send on every request through the proxy. Then it will need to be handled in nodebackend as well.

As I cant prioritize this right now and it's not urgent, I would prefer more additions to userDetails as a new issue in both Hajk-repo and NodeHoster-repo. What do you think?

from hajk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.