Code Monkey home page Code Monkey logo

Comments (16)

FrankGiesecke avatar FrankGiesecke commented on September 22, 2024 1

The problem seems to be, that some errors/warnings/infos are not displayed in the log.
I have a Dockerfile which doesn't contain any ignore statements.
In my first run, my .hadolint.yaml only contains the exclusion for DL3018.
If I run Hadolint from CLI, I get the message:

Dockerfile:13 DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation.

But in the CI, no message is displayed but the step fails.

If I add the exclusion for DL3059, the CI step succeeds.

from hadolint-action.

hatamiarash7 avatar hatamiarash7 commented on September 22, 2024

I have this problem too

from hadolint-action.

FrankGiesecke avatar FrankGiesecke commented on September 22, 2024

Same problem an currently no solution 😒

from hadolint-action.

erzz avatar erzz commented on September 22, 2024

I hate to leave me too messages - but me too :)

Also I believe that if you write the report to file it also is empty

from hadolint-action.

ViacheslavKudinov avatar ViacheslavKudinov commented on September 22, 2024

Same here.
Had to switch back to v2.0.0, this works fine.

from hadolint-action.

ReenigneArcher avatar ReenigneArcher commented on September 22, 2024

I've been experiencing this same issue for a couple of months. Is this project still maintained? Last activity seems to be in May.

from hadolint-action.

ReenigneArcher avatar ReenigneArcher commented on September 22, 2024

I found that if you re-run the job with debug logging enabled you will see some output.

from hadolint-action.

brpaz avatar brpaz commented on September 22, 2024

For me it worked to set failure-threshold to error or warning

According to the documentation, the default is info. I donΒ΄t know how this works internally in Hadolint, but my theory, is that info is making the pipeline fail with any output, even if it has no errors.

Ex:

 - name: Lint Dockerfile
    uses: hadolint/[email protected]
    with:
      dockerfile: Dockerfile
      failure-threshold: error

error should probably be the default value, as I think this is what most people would like to fail the pipeline and then they could override to warning for a more strict workflow.

from hadolint-action.

maxhelias avatar maxhelias commented on September 22, 2024

Not sure but this seems to be related to #55

from hadolint-action.

rene-bos avatar rene-bos commented on September 22, 2024

This issue has been fixed by the 3.0.0 release for us (we also pinned at 2.0.0 to avoid having this problem).

from hadolint-action.

maxhelias avatar maxhelias commented on September 22, 2024

I still have it on 3.0.0 and even on master : https://github.com/dunglas/symfony-docker/actions/runs/3765268860/jobs/6400565741

from hadolint-action.

DracoBlue avatar DracoBlue commented on September 22, 2024

You need to set output-file to /dev/stdout.

I added a PR for this at #71

from hadolint-action.

humphd avatar humphd commented on September 22, 2024

Setting v3.0.0 up tonight, and it fails like many people are mentioning above, unless I explicitly include failure-threshold: error:

    steps:
      - name: Checkout code
        uses: actions/checkout@v3
      - name: Run Hadolint on Dockerfile
        uses: hadolint/[email protected]
        with:
          dockerfile: Dockerfile
          # it will fail with no error if I omit this...
          failure-threshold: error

from hadolint-action.

DracoBlue avatar DracoBlue commented on September 22, 2024

@humphd please use 3.1.0 and the error messages should be visible

from hadolint-action.

DracoBlue avatar DracoBlue commented on September 22, 2024

I created a PR at #75 to ensure people are not copying v3.0.0 from the README.md

from hadolint-action.

humphd avatar humphd commented on September 22, 2024

@DracoBlue that's excellent, thank you for the info and fixing the README. Appreciated.

from hadolint-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.