Comments (16)
The problem seems to be, that some errors/warnings/infos are not displayed in the log.
I have a Dockerfile which doesn't contain any ignore statements.
In my first run, my .hadolint.yaml
only contains the exclusion for DL3018
.
If I run Hadolint from CLI, I get the message:
Dockerfile:13 DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation.
But in the CI, no message is displayed but the step fails.
If I add the exclusion for DL3059
, the CI step succeeds.
from hadolint-action.
I have this problem too
from hadolint-action.
Same problem an currently no solution π’
from hadolint-action.
I hate to leave me too messages - but me too :)
Also I believe that if you write the report to file it also is empty
from hadolint-action.
Same here.
Had to switch back to v2.0.0, this works fine.
from hadolint-action.
I've been experiencing this same issue for a couple of months. Is this project still maintained? Last activity seems to be in May.
from hadolint-action.
I found that if you re-run the job with debug logging enabled you will see some output.
from hadolint-action.
For me it worked to set failure-threshold
to error
or warning
According to the documentation, the default is info
. I donΒ΄t know how this works internally in Hadolint, but my theory, is that info
is making the pipeline fail with any output, even if it has no errors.
Ex:
- name: Lint Dockerfile
uses: hadolint/[email protected]
with:
dockerfile: Dockerfile
failure-threshold: error
error
should probably be the default value, as I think this is what most people would like to fail the pipeline and then they could override to warning for a more strict workflow.
from hadolint-action.
Not sure but this seems to be related to #55
from hadolint-action.
This issue has been fixed by the 3.0.0 release for us (we also pinned at 2.0.0 to avoid having this problem).
from hadolint-action.
I still have it on 3.0.0 and even on master : https://github.com/dunglas/symfony-docker/actions/runs/3765268860/jobs/6400565741
from hadolint-action.
You need to set output-file to /dev/stdout.
I added a PR for this at #71
from hadolint-action.
Setting v3.0.0
up tonight, and it fails like many people are mentioning above, unless I explicitly include failure-threshold: error
:
steps:
- name: Checkout code
uses: actions/checkout@v3
- name: Run Hadolint on Dockerfile
uses: hadolint/[email protected]
with:
dockerfile: Dockerfile
# it will fail with no error if I omit this...
failure-threshold: error
from hadolint-action.
@humphd please use 3.1.0 and the error messages should be visible
from hadolint-action.
I created a PR at #75 to ensure people are not copying v3.0.0 from the README.md
from hadolint-action.
@DracoBlue that's excellent, thank you for the info and fixing the README. Appreciated.
from hadolint-action.
Related Issues (20)
- How recursive scan from a defined directory? HOT 1
- Improvements: no-fail flag and file output
- Error: Unable to process command '::add-matcher::./tmp.nA8912gdP6/problem-matcher.json' HOT 1
- Release management: improve semantic versioning HOT 2
- Reported issues wont fail the build HOT 1
- Enable dependabot in Settings HOT 1
- How to lint multiple dockerfiles, without specifying the action for each? HOT 2
- [INVESTIGATED/TESTED] Configuration File Pathing Issue + Subsequent Issue HOT 2
- Provide v2 HOT 1
- `set-output` deprecation
- Problem matcher picks up issues that were ignored in the config file
- How to use hadolint action within organization repo? HOT 1
- Capture severity in problem matcher
- received unexpected HTTP status: 503 Service Unavailable HOT 2
- withBinaryFile: does not exist (No such file or directory) HOT 3
- Dockerfile is a directory
- Jenkins Piplines unable to check multeple dockerfiles.
- hadolint-action builds out of turn
- Pull hadolint image from local registry
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hadolint-action.