Code Monkey home page Code Monkey logo

Comments (5)

computron avatar computron commented on August 16, 2024

(maybe @WardLT @JFChen3 for the latter improvements to featurize_dataframe() ?)

from matminer.

WardLT avatar WardLT commented on August 16, 2024

Nice! I didn't realize you could group columns this way. The code looks decently straightforward. I could give it a shot for marking which featurizer a feature comes from for MultiFeaturizer.

from matminer.

computron avatar computron commented on August 16, 2024

@ardunn do you consider this complete? if so can you close?

from matminer.

ardunn avatar ardunn commented on August 16, 2024

@computron This is definitely not complete. I removed it from a previous PR because it made the PR too complicated. It is on the "todos" though

Edit:

@WardLT if you have a good idea/gameplan for implementing this, feel free to take it over. I am finding that for basic multiindexing it is okay, but when using inplace or with MultiFeaturizer, multiindexing introduces a lot of code complexity for such a small increase in utility.

from matminer.

computron avatar computron commented on August 16, 2024

How about skipping MultiFeaturizer and inplace for now?

  • For MultiFeaturizer give it all the same group heading, "multifeaturizer" or something
  • For inplace, just leave the same group that you had before and don't mess with it

Would that allow the issue to at least be partially solved and usable?

from matminer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.