A few Proposal(s) : CLI args improvement, GitHub Enterprise support about labels HOT 2 OPEN

Hi @tprasadtp! 👋

Thank you for your suggestions. Here are my thoughts on the individual items:

1. We currently use HTTP basic authentication and accept a username and a token. It is my understanding that this method is still supported and not subject of the announced deprecations

2. I believe that is how sub-commands are designed in click. Can you please describe what a help message you would expect?

3. I'm happy to review pull-requests for adding a new CLI option for the API URL. 👍

4. As a user, I would find it more helpful if labels tells me that it's missing a required parameter, rather than it silently loading generic environment variables. Chances are that people already have a GITHUB_TOKEN that is not set to the token with the correct scope for labels.

5. Let's not introduce breaking changes unless it's strictly necessary. ⚠️

6. Sure, we can build a Docker image with GitHub actions and publish to GitHub Packages. 🤖

7. What would be the benefit of a self contained static binary over Installing the package from PyPI or pulling the Docker image from GitHub?

8. The labels source code is formatted with black. We could add pre-commit or automation for isort and black though. 🙂

from labels.

Thank you,

We currently use HTTP basic authentication and accept a username and a token. It is my understanding that this method is still supported and not subject of the announced deprecations

Yes, because we use tokens, username is not necessary if we authenticate with headers. I thought it would be better because that's one less argument to specify https://developer.github.com/v3/#oauth2-token-sent-in-a-header

I believe that is how sub-commands are designed in click. Can you please describe what a help message you would expect?

I understand that. I would expect the following to be the help message. But to see that I have to specify -u and -t

labels -t 1bc -u none fetch --help
Usage: labels fetch [OPTIONS]

  Fetch labels for a GitHub repository.

  This will write the labels information to disk to the specified filename.

Options:
  -o, --owner TEXT     GitHub owner name  [required]
  -r, --repo TEXT      GitHub repository name  [required]
  -f, --filename PATH  Filename for labels  [required]
  --help               Show this message and exit.

I am not exactly sure how to overcome that other than making them arguments to subcommands.
as its click's limitation.

I'm happy to review pull-requests for adding a new CLI option for the API URL

I need to test it with custom CA and then I will submit a PR.

Sure, we can build a Docker image with GitHub actions and publish to GitHub Packages.

I just found out that GitHub packages does not support un-authenticated docker pulls yet.:(

What would be the benefit of a self contained static binary over Installing the package from PyPI or pulling the Docker image from GitHub?

If docker images are provided then I don't think its necessary.

The labels source code is formatted with black. We could add pre-commit or automation for isort and black though.

That's a good idea.

from labels.