Infinite gold about habitica HOT 15 CLOSED

Lol! Don't you people know the Konami code? Jk, i'll fix this thanks.

from habitica.

When you get all that wonderful negative gold... and buy everything...

There's a blank for armor and weapons above gold level.

That was fun...

from habitica.

If this is still an open issue I'll tackle it tomorrow.

from habitica.

It is. All I think that needs to be done is to remove being able to add a negative number as a reward.

from habitica.

@Andrew565 check out https://github.com/chriso/node-validator while you're in there.

from habitica.

We could use:

money -= Math.abs(taskObj.value)

in the scoring.coffee file to have the reward always cost gold until we work out the validation.

Edit: OK. I think I uploaded the files correctly. That should fix it and stop any more free gold from getting out.

from habitica.

I hope @lefnire can get a look at this. The question is though, will this also work if we put in "asdfs" ?

So far this caused the GP counter to become NaN and this means buy whatever you like until a day reset ;)

It would also be nice to have something like this while setting the value. I don't know about the syntax but something like:

money = Math.abs(taskObj.value)
if(money ==NaN){
//display some error
}else{
// create task
}

from habitica.

It reverts back to the unedited value if a non-number is entered and gives a tooltip with an error when a negative value is entered.

from habitica.

Is this included in your pull request :) ?

from habitica.

Yes. My update should fix it.

from habitica.

Cool :) Well then I hope Tyler can take a look at your pull request soon :)
Although I must say the negative gold is Very useful when testing on the
test server ;)

On Mon, Feb 4, 2013 at 11:18 PM, Sabin144 [email protected] wrote:

Yes. My update should fix it.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/47#issuecomment-13103031.

from habitica.

merged, will go out with the next push. @Pandoro, once I get some proper accessControl in I'll build some debug tools for us - maybe activated by the Konami Code ;)

from habitica.

Checking and unchecking a daily will produce infinite gold, albeit in small increments.

from habitica.

Adding to what tjwds said, you can also keep all the item drops from clicking and unclicking the dailies. Includes pets, food, crits, and hatching potions. (Crits meaning that critical hits will keep the difference in exp too.)

from habitica.

That's not an issue wrt drops, considering there's a drop cap. I'm also not
really concerned about this simply because well, if people are that into
button clicking and missing the point of Habit... they should enjoy their
gold? It would be a lot easier to go into Fix Character Values.

On Thu, Apr 24, 2014 at 10:23 PM, lcnv [email protected] wrote:

Adding to what tjwds said, you can also keep all the item drops from
clicking and unclicking the dailies. Includes pets, food, crits, and
hatching potions. (Crits meaning that critical hits will keep the
difference in exp too.)

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/47#issuecomment-41359885
.

from habitica.