Code Monkey home page Code Monkey logo

Comments (5)

h2zero avatar h2zero commented on May 13, 2024

Hi, thanks for testing it out 😃 .

Long reads and writes will be implemented shortly, I have the test code in place currently in the bugfix branch, although commented out for now. It needs more work as NimBLE doesn't really provide a great way to detect when a long write or write is in progress so I need to stumble through the source code a bit more. With luck it won't be too much longer.

from nimble-arduino.

chegewara avatar chegewara commented on May 13, 2024

I dont know NimBLE, but here is how long read is solved in old library (its in bluetooth specs):
https://github.com/nkolban/esp32-snippets/blob/master/cpp_utils/BLECharacteristic.cpp#L373

IIRC long write is handled by WRITE_EVT and param->write.is_prep, and finally by EXEC_WRITE_EVT (im not sure about last event).

PS i am wondering if its required to write long read/write code or its maybe handled internally by NimBLE

from nimble-arduino.

h2zero avatar h2zero commented on May 13, 2024

@chegewara Thanks for the link, sadly it doesn't seem NimBLE provides any sort of indication flag for long read/write.

The best I can do it seems is compare the data size with the mtu the check the packet header length that may give an indication if this is an initial read or followup. I think it does handle the offset internally though so hopefully that won't need to be managed.

from nimble-arduino.

schlaegerz avatar schlaegerz commented on May 13, 2024

I figured out I could fix my case by negotiating a higher mtu from the client side.

I'm not sure if that should be the standard way to do it or if the package should somehow combine it.

from nimble-arduino.

h2zero avatar h2zero commented on May 13, 2024

Long reads and writes are sub-optimal, they consume a lot of time. It's much better to use the biggest MTU size you can handle.

That said, I have sorted out the long read/write situation in the server code and just now pushed the update to the bugfix branch if you want to check it out.

from nimble-arduino.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.