Code Monkey home page Code Monkey logo

Comments (5)

mturoci avatar mturoci commented on May 18, 2024

In addition to points above, since tslint is deprecated, I am going to replace it with typescript-eslint as suggested in the official docs.

from wave.

mturoci avatar mturoci commented on May 18, 2024

Other possible improvements regarding git hooks:

  • Consistent commit message format (e.g. conventional commits).
  • Implement git hooks for the whole repo and add support for linting staged files other than JS - (.py, .md, .go).

@lo5 @geomodular

from wave.

lo5 avatar lo5 commented on May 18, 2024

Agree @mturoci - I'm fine with conventional commits as long as the [optional scope] part is not enforced.

from wave.

mturoci avatar mturoci commented on May 18, 2024

In order to enforce git hooks for each developer I use husky in combination with lint-staged for linting.

It works fine for ui part of repo since I have included it in package.json there. However, if we want to use it for the whole repo, I would have to create a package.json and corresponding node_modules in project root and set it all there.
Despite the fact I think project root should not be polluted with nodejs or any other language specific files other than configs, I could not find any other way around it.

Problem no. 2 is that for commit linting and markdown linting there exist npm packages, go has native linter as part of an SDK, but the problem is python one. As far as I discovered, python requires pip installing the linter locally. This would introduce requirements.txt in project root. @lo5 any idea as someone who has much broader python experience? Please also read the previous section.

from wave.

mturoci avatar mturoci commented on May 18, 2024

Adding .nvmrc with current LTS Node version (via @mnezh)

from wave.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.