Comments (5)
In addition to points above, since tslint is deprecated, I am going to replace it with typescript-eslint as suggested in the official docs.
from wave.
Other possible improvements regarding git hooks:
- Consistent commit message format (e.g. conventional commits).
- Implement git hooks for the whole repo and add support for linting staged files other than JS - (
.py
,.md
,.go
).
from wave.
Agree @mturoci - I'm fine with conventional commits as long as the [optional scope]
part is not enforced.
from wave.
In order to enforce git hooks for each developer I use husky in combination with lint-staged for linting.
It works fine for ui
part of repo since I have included it in package.json
there. However, if we want to use it for the whole repo, I would have to create a package.json
and corresponding node_modules
in project root and set it all there.
Despite the fact I think project root should not be polluted with nodejs or any other language specific files other than configs, I could not find any other way around it.
Problem no. 2 is that for commit linting and markdown linting there exist npm packages, go has native linter as part of an SDK, but the problem is python one. As far as I discovered, python requires pip installing the linter locally. This would introduce requirements.txt
in project root. @lo5 any idea as someone who has much broader python experience? Please also read the previous section.
from wave.
Adding .nvmrc
with current LTS Node version (via @mnezh)
from wave.
Related Issues (20)
- Improve markdown typography via nicer defaults
- Integrate github workflows to automate the air-gapping process of Wave Tour App
- Add support for preview links for public sharing HOT 1
- Waved panicked HOT 14
- wave fetch command returning a 404 on MacOS arm64 HOT 1
- Enable "production-level" on-screen logging, versus showing stack traces (aka "error boundary") HOT 1
- Allow for installing arbitrary packages in Wave-studio
- Table `select` event prevents correct execution of other table events HOT 2
- Add `name` attribute to ui.stats HOT 1
- By-name component access not working for updated items
- Dialog forms have inconsistent `q.args` behavior HOT 2
- Inform developers if they try to update a component or that does not exist.
- `run_on` stops routing to `#foo` after a textbox `trigger=True` HOT 1
- trigger=True on textbox causes text not to appear in args when the Form's button is clicked. HOT 1
- Add Download ability to ui.command
- File upload not working when waved run separately. HOT 3
- Conda install works with python 3.11 only HOT 3
- Add `flex-grow`/`flex-shrink` option to components within `ui.inline`
- Allow different origins for the websocket connection. RunPod Issue
- Wave app crashes when selecting filter for a column HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wave.