Comments (3)
In our coding style, we intentionally allow use of some C99 dialects; see https://github.com/h2o/h2o/wiki/Coding-Style.
@kazuho Oh! I hadn't realized that. Since the warning is caused by only three lines of code, I thought this library supported ANSI C. PR #80 should be rejected then and I will close this issue if you prefer.
Thanks.
from picohttpparser.
Thank you for opening the issue and filing a PR.
In our coding style, we intentionally allow use of some C99 dialects; see https://github.com/h2o/h2o/wiki/Coding-Style.
Would it be possible for you to solve the issue by changing the compiler options?
from picohttpparser.
Just to chime in as a user of the library. C99 is now 25 years old. Lack of tooling for fringe platforms should not be an argument to compromise on the code clarity and all features listed in #2188 greatly improve the code style.
As a matter of fact, I am big fan of all C code should gradually move to at least C11/C17, but thatβs another story ;)
from picohttpparser.
Related Issues (20)
- Possible typo
- Correctly detect obsolete header line folding
- version number
- Questions about how to use picohttpparser? HOT 2
- Official release and git tag?
- Not able to properly parse using ruby FFI HOT 1
- Is it possible to avoid reallocation during chunked data processing?
- Is it possible to construct responses HOT 1
- What last_len actually means? HOT 2
- now is support https ? HOT 2
- Mystifying HTTP Response
- about http response "chunked" and "gzip".
- Can we use ranges2[16]="\000\040\177"? HOT 1
- Support for request body parsing HOT 1
- Dead / duplicated code in `is_complete()`
- Examples HOT 2
- Overly aggressive slowloris check? HOT 1
- `phr_parse_request()` partial parsing doesn't seem to work HOT 2
- Assert issue with parsing double quotes HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from picohttpparser.