Support `io.BytesIO` as input about filetype.py HOT 7 CLOSED

Hi @ferstar,
Although this fix addresses this specific issue, not all file-like objects inherit from io.BufferedIOBase; for instance, all file-like objects used in Django.

We have been using this package for a long time to determine uploaded file types, but after upgrading to version 1.1.0, we received the same TypeError. As a workaround, we just read the first 262 bytes and pass them to the guess function and after the new version is released, we can just pass the underlying file object. However, it will be just a specific workaround for django.

Can I ask about the reasoning behind this commit? Since the try clause didn't seek to the start position, I can see that it could introduce unexpected side-effects, but isn't it more useful to check if the object has read, tell, and seek attributes instead of checking inheritance from io.BufferedIOBase?

Thanks

from filetype.py.

Hi @ferstar and @h2non
Any idea when we can expect a release to pypi of this fix?
Many thanks

from filetype.py.

It should be working on v1.2.0, now available on PyPI:
https://pypi.org/project/filetype/

from filetype.py.

@jams2 I have fix this in fix: restore reader position after retrieving signature bytes

But it seems we need @h2non to push the latest code to pypi

from filetype.py.

@ferstar that's great, thanks. Looking forward to the release.

from filetype.py.

@pooriazmn Thanks for pointing this out. Attribute judgment for read/seek/tell should be a better choice to be compatible with more object types. I have fixed it.

from filetype.py.

Thanks for pushing it into PyPI, @h2non ! It works perfectly. Cheers

from filetype.py.