Comments (8)
I don't think it's a good idea to downgrade to 5.3 at this point. It would require additional dev time to ensure 5.3 compatibility, and that's something that most of the PHP community is moving away from supporting. Maybe you can create a 5.3 compatible fork.
from psr7.
What if I will create a PR instead?
So far I can see that []
are used instead of array()
and traits. Traits can be replaced with base classes since all classes that use traits do not extend anything and only implement the interface.
If the downgrade would be rather painless, then why not...
from psr7.
It's not a one time cost. It's also maintenance going forward.
On Jul 29, 2015, at 10:58 PM, Kirill Konshin [email protected] wrote:
What if I will create a PR instead?
So far I can see that [] are used instead of array() and traits. Traits can be replaced with base classes since all classes that use traits do not extend anything and only implement the interface.
β
Reply to this email directly or view it on GitHub.
from psr7.
Do you have anything special in the roadmap for this project?
from psr7.
Will you accept a PR or should I just make a fork?
from psr7.
You should fork if you need PHP 5.3 support. Apologies, but I don't want to support 5.3 in this repo.
from psr7.
Since in our company we have a requirement to support 5.3 and Guzzle\PSR7 will be used in company PHP SDK I think I can support 5.3 on long term. I will fork the repo then make a PR, but it's up to you to accept it.
from psr7.
Made a PR #30
from psr7.
Related Issues (20)
- Missing typehints HOT 1
- GuzzleHttp\Psr7\Uri Incorrectly filled port, when converted to a string HOT 2
- Message::toString throw error when headers is list array HOT 1
- Content-Type assumption not done if the file don't have extension HOT 4
- $response->getBody()->getContents() returns empty string HOT 4
- "HTTP/2 200 is not valid header value" on 2.5.0 HOT 11
- AAC MimeType has a Typo HOT 5
- Remove ralouphie/getallheaders dependency ? HOT 5
- Exception in \GuzzleHttp\Psr7\Message::toString with poor (numeric) header HOT 3
- `Uri::__toString()` can yield malformed URIs HOT 1
- Header::parse loosing cookies with same name
- Declaration Error in GuzzleHttp\Psr7\Uri because of missing type hint for arguments. HOT 5
- summarize the multibytes(utf8) payload stream maybe cause the content unreadable
- Cross Origin - Allow optional protocol upgrade HOT 4
- StreamWrapper::stream_stat() should not always return an array
- Parsing Link header doesnβt handle URLs with commas HOT 1
- Header validation (InvalidArgumentException : ":<header>" is not valid header name) HOT 6
- Change \GuzzleHttp\Psr7\Utils::modifyRequest to keep initial Request object with modifications instead of creating new Request
- Support non standard HTTP status codes HOT 4
- Body resource cannot be detached when using `ServerRequest::fromGlobals()`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from psr7.