Totally Broken With Guzzle 5 about guzzle-services HOT 12 CLOSED

All the tests pass though: https://travis-ci.org/guzzle/guzzle-services

Is there something missing that needs to be covered?

from guzzle-services.

I'll look into it shortly.

from guzzle-services.

Ok, my first step is to be 1000% sure that this isn't caused by an issue in my code. This was confirmed by me checking it worked with guzzle 4: GrahamDeprecated/Laravel-CloudFlare-API@468e321. The results from that manual test were that, yes, everything definitely works with guzzle 4.

I then reinstalled guzzle 5, then tried disabling my 2 subscribers to make sure they weren't interfering, and they weren't - disabling them made no difference.

Third step - look for changes to the guzzle classes I'm interacting with - there are no real changes, only changes to type hints.

I'm now going through the guzzle code trying to work out at which point the response variable isn't set correctly...

from guzzle-services.

At this point: https://github.com/guzzle/guzzle-services/blob/master/src/Subscriber/ProcessResponse.php#L98, the response variable is null. What's going on there?

from guzzle-services.

Ahh. Your code comment says that this is allowed to be null if there was an http error. https://github.com/guzzle/command/blob/master/src/Event/ProcessEvent.php#L45

from guzzle-services.

But then you assumed that it was always a response object in that other subscriber. Also, I'm struggling to see how there could have been an http error?

from guzzle-services.

I'll try attaching the log subscriber later tonight.

from guzzle-services.

OH, JUST WOW!

[2014-10-24 18:10:39] cloudflare-api.CRITICAL: GRAHAM-WIN7 Guzzle/5.0.1 curl/7.36.0 PHP/5.6.0 - [2014-10-24T18:10:39+00:00] "GET /api_json.html?a=stats&tkn=349f0d06c82cf202b46fc0efa9c44cb8079cc&email=a%40starbs.net&z=grahamjcampbell.co.uk&interval=20 /" NULL NULL {"request":"[object] (GuzzleHttp\\Message\\Request: {})","response":null,"exception":"[object] (GuzzleHttp\\Exception\\RequestException: cURL error 60: SSL certificate problem: unable to get local issuer certificate at C:\\Program Files (x86)\\EasyPHP-DevServer-14.1VC11\\data\\localweb\\vendor\\guzzlehttp\\guzzle\\src\\Exception\\RequestException.php:51, GuzzleHttp\\Ring\\Exception\\RingException: cURL error 60: SSL certificate problem: unable to get local issuer certificate at C:\\Program Files (x86)\\EasyPHP-DevServer-14.1VC11\\data\\localweb\\vendor\\guzzlehttp\\ringphp\\src\\Client\\CurlFactory.php:129)"} []

from guzzle-services.

Although this is due to a misconfiguration of php on my part, guzzle should still handle this error correctly, instead of just a cryptic error that took a fair bit of digging to work out what was going on.

from guzzle-services.

Seems like there just needs to be a conditional check in https://github.com/guzzle/guzzle-services/blob/master/src/Subscriber/ProcessResponse.php#L98 that ensures a response is present. Once added, the underlying HTTP exception will eventually be thrown.

from guzzle-services.

This is now fixed and I added a test case.

from guzzle-services.

Great. Thanks. :)

from guzzle-services.