Support for GitHub appliances about git-repo HOT 5 CLOSED

I'd be very happy to add such a feature, but sadly I have no access to such appliance, I have no idea what would be the differences with github.com, and how to write tests for them.

So I'd be happy to accept a PR to integrate it (basically adding the fqdn = feature there already is for gitlab), or write a patch if I'm given access to one appliance (is github hosting an accessible test instance somewhere?).

from git-repo.

I'll see about both options--I can try my hand at just adding an FQDN option, and seeing if replacing "github.com" with it everywhere "just works". And I can see about whether we can grant any access. It would be difficult, though, as our GitHub appliance authenticates against our LDAP here at the U and there are politics involved.

I'd also be curious whether there's the possibility to test an appliance--perhaps they can make a virtual machine image available somehow for that? That would come in handy here at the U even beside the point of us wanting this awesome tool. :->

from git-repo.

I can try my hand at just adding an FQDN option, and seeing if replacing "github.com" with it everywhere "just works"

Well, actually, it's totally untested, but you might want to try to setup fqdn in the github section of your configuration, and see how it goes, it might just work… I just looked at the code again, and I'm using in the github service the same mechanism I'm using to make gitlab fqdn agnostic.

So there are chances it might just work with:

[gitrepo "umn"]
    type = github
    alias = umn
    fqdn = github.umn.edu
    privatekey = YOURPRIVATEKEY

Though, it's totally untested and never tried, so here be dragons ☺

If it works, there are a couple of places to modify, to make the gists work (which have the gist.github.com fqdn hard coded).

And I can see about whether we can grant any access. It would be difficult, though, as our GitHub appliance authenticates against our LDAP here at the U and there are politics involved.
I'd also be curious whether there's the possibility to test an appliance--perhaps they can make a virtual machine image available somehow for that?

Well, if you could make that work, why not, but TBH, I believe that it should be github that provides a test instance for us to make it possible to test that and make it work… And maybe even implement the very custom features that might be for the appliances version, that does not exists for the public version ☺

from git-repo.

@kozmikyak did it work?

from git-repo.

ok, no news for a while, I'll consider it's working, as anyway I have no ways to actually test it.

Reopen if needed!

from git-repo.