Code Monkey home page Code Monkey logo

Comments (3)

daemonsy avatar daemonsy commented on May 17, 2024

Reproduction

I spent some time investigating this and made some progress in reproducing this issue.

We have an option in semantic release rubygems that installs and update lockfiles of the appraisal to the latest version of the gem after release. That's pretty neat, it means all the specs are declared to run on the latest version.

In the config, we have an option updateGemfileLock that runs bundle exec appraisal install. Just for context, after this, the files are committed by semantic release bot using the git plugin.

This in terms generates statements like:

bundle check --gemfile='/Users/damon.aw/code/apollo-federation-ruby/gemfiles/graphql_1.10.gemfile' || bundle install --gemfile='/Users/damon.aw/code/apollo-federation-ruby/gemfiles/graphql_1.10.gemfile' --retry 1
bundle check --gemfile='/Users/damon.aw/code/apollo-federation-ruby/gemfiles/graphql_1.11.gemfile' || bundle install --gemfile='/Users/damon.aw/code/apollo-federation-ruby/gemfiles/graphql_1.11.gemfile' --retry 1
bundle check --gemfile='/Users/damon.aw/code/apollo-federation-ruby/gemfiles/graphql_1.12.gemfile' || bundle install --gemfile='/Users/damon.aw/code/apollo-federation-ruby/gemfiles/graphql_1.12.gemfile' --retry 1

Running this locally by bumping the gem version, I realized the bundle check command seems to change our Gemfile.lock in the main repo.

I've confirmed that adding --dry-run option stops the bundle check from changing the lockfiles.

Next steps

  1. File an issue to Rubygems

  2. We could just run bundle exec appraisal install to avoid calling bundle check for now.

from apollo-federation-ruby.

daemonsy avatar daemonsy commented on May 17, 2024

rubygems/rubygems#5325

from apollo-federation-ruby.

grxy avatar grxy commented on May 17, 2024

Closing this since I believe it was fixed at some point when the bundler version was upgraded.

from apollo-federation-ruby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.