Code Monkey home page Code Monkey logo

Comments (2)

nukes avatar nukes commented on July 22, 2024

I see, you use inline for keep this header work in multiple files. But i find some methods are still not inline,which makes the problem.
I can successfully compile by fix the methods by add "inline" keyword, but i think it is not a good solution as the code size grows a lot in my case.
I think a separate the implementation into .cc file is still a good idea.

from filesystem.

gulrak avatar gulrak commented on July 22, 2024

Indeed some inlines where missing. I missed adding a test to ensure that including it into multiple implementation files works. I'll push a fix for that.

I understand, that there are arguments for a separated approach, but this is explicitly designed as a header-only/single-file solution, so currently there are no plans for separation into a .h/.cpp pair of files or even more files.

I once had an early version that supported separation by including the header with specific defines for implementation or forwarding header, but the effect was not as relevant as I had hoped, the code got quite a bit uglier to work with, and with link-time-optimization (-flto on gcc) most redundancies are dropped from the binary.
Still if multiple shared libraries are including this header, it might make more of a difference, but the results of that tests pushed the feature down the list.

from filesystem.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.