Comments (11)
@doowb any thoughts on this?
from glob-stream.
I'm guessing resolveGlob
is removing the separator that is added?
from glob-stream.
I'm looking into this and enabled appveyor on my fork to test out a solution.
resolveGlob
will keep the trailing slash if it's already there but it only handles /
.
I'm not sure if this should be handled in resolveGlob
or if it should be done here.
I think it should be done here because when using an absolute path and the root
option, the glob parent before being expanded is turning into /
. I think it's just that case that needs to be handled.
@phated will you enable appveyor for this repo... I've added an appveyor config file on my fork and I can submit a PR when it's fixed and we'll be able to see the tests in that PR.
Oh... and I had to change the jscs
pattern in the package.json from *.js
to .
for it to work on windows.
from glob-stream.
I had been meaning to turn on appveyor for this project but was going to do it when I normalized the project. I've gone ahead and enabled it now.
from glob-stream.
Just did a PR. It handles the different cases that I ran across when trying different implementations. Since the tests are already using path.sep
they're valid for all environments.
from glob-stream.
I test the PR and it works fine for me
from glob-stream.
Fix published as 5.3.4
from glob-stream.
@danivek As I've been working on the next major release of glob-stream
, it seems to make sense to remove the trailing separator on the base
property. We are already going to be removing it in Vinyl, so it seems counterintuitive to include it here and then remove it again. Do you know what plugins broke with this change before? I'd like to review them and see if they aren't using path.join
or other path.*
utilities like is typically expected.
from glob-stream.
@phated the plugin having the issue was gulp-angular-templatecache
from glob-stream.
@danivek thanks! It seems like they are properly handling separators or no-separators in the base
property but I'm not sure why they are doing some of the things. Unfortunately, that module is breaking the plugin guidelines by combining other plugins internally, so I'd recommend moving away from it.
from glob-stream.
@phated thanks for your advice. Never mind, i will switch to a more stable tool webpack
from glob-stream.
Related Issues (20)
- Update pumpify HOT 3
- [SPAM] Update glob-parent dependency to 5.1.2 or higher HOT 1
- glob-parent version vulnerability
- Bump glob-parent to resolve ReDos Vulnerability HOT 1
- Dependency vulnerability - Glob-parent HOT 1
- Switch to streamx
- Investigate fast-glob HOT 2
- Lists only 16 or less files when a glob string including no globstar. HOT 15
- Avoid mutating the options passed to `create`
- Support custom `unique` filtering through option HOT 1
- Should `create` accept a non-array ignore option HOT 2
- Docs: Note we don't pass `root` option to node-glob
- Remove path normalization? HOT 1
- Implement the streaming globber as a real Readable stream instead of a through stream HOT 2
- Base directory not copying correctly HOT 4
- Flakey tests HOT 1
- How can I use it with gulp? HOT 1
- Can't install glob-stream - ECONNRESET error HOT 1
- How to properly read chunks of all files content into a single stream? HOT 3
- npm audit returns errors. HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from glob-stream.