Use Minimatch class for improved perf about glob-stream HOT 5 CLOSED

Before I send a PR to fix this, does glob-stream's globs argument support anything other than strings? There's this typeof pattern !== 'string' and pattern instanceof RegExp, but there are no docs nor tests regarding these apparently. Can these be removed safely?

from glob-stream.

@UltCombo We do support custom RegExps at the post-scan level https://github.com/wearefractal/glob-stream/blob/master/index.js#L104 I'd like to keep that if possible

from glob-stream.

@contra Oh I see. But https://github.com/wearefractal/glob-stream/blob/master/index.js#L109 shouldn't be return false;? Or are RegExps considered as negative globs for some reason? I can't seem to find any unit test using RegExps.

from glob-stream.

@UltCombo All RegExps are treated as negative since they are used to filter post-scan which means they cannot be positive. You can't give a regex to node-glob so there is no way it could be positive. There probably aren't tests if you can't find any, but there should be

from glob-stream.

Oh I see, thanks for the explanation :)
I'll write some tests for those as well after I get this working.

from glob-stream.