Comments (12)
When faced with the same issue, I've moved all source files to a src
subdirectory (sibling of node_modules
), then you can just use a simple src/**/*.js
glob.
from glob-stream.
Don't glob things under node_modules. Remove the **
from glob-stream.
Negation is done post-read right now which is kind of crappy. the node-glob module which we use to find results does not accept multiple globs, so there is no way for us to negate prior to that. If we switch to a new glob module or that module adds support for negation it will speed things up a ton. Really, this is probably one of the biggest bottlenecks in gulp.
from glob-stream.
@contra should we still support regex (post-read) filtering after implementing node-glob's ignore
option?
from glob-stream.
@UltCombo Yeah I think so
from glob-stream.
Alright then, I'll have a PR in 30~45mins.
from glob-stream.
@UltCombo Any update on this?
from glob-stream.
from glob-stream.
nearly have a working PR for this, there's one test broken:
'should return a file name stream with dotfiles negated'
and it's timing out at 2000ms.
Any thoughts on what that might be, for some reason the stream is not emitting anything.
https://github.com/thirdcreed/glob-stream/blob/master/index.js
from glob-stream.
Even when I set the timeout for that test to 15 seconds, it doesn't emit. It runs in like <1 sec when using glob.sync. So I know something's up.
node -p 'require("glob").sync("/home/thirdcreed/Projects/glob-stream/test/fixtures/*swag",{ignore:["/home/thirdcreed/Projects/glob-stream/test/fixtures/**"],dot:true,cwd: "/home/thirdcreed/Projects/glob-stream/test",cwdbase:false,nonull:false})'
That returns [ ], like it should. The ignore actually works, whereas random text in the ignore would allow .swag in, the above command does not; those are the exact parameters being sent into glob.Glob();
The ignore code is 8 days old, so it could be a bug in there, I'm starting to dive in, but any kind of expertise here would be much appreciated. Thanks!
from glob-stream.
any update to this issue? I encounter a similar problem without negation though.
from glob-stream.
I think this is the same as another ticket - the ** is being expanded by recursing the fs (this is how globs work). Using !node_modules
instead of !node_modules/**
should fix it.
from glob-stream.
Related Issues (20)
- Update pumpify HOT 3
- [SPAM] Update glob-parent dependency to 5.1.2 or higher HOT 1
- glob-parent version vulnerability
- Bump glob-parent to resolve ReDos Vulnerability HOT 1
- Dependency vulnerability - Glob-parent HOT 1
- Switch to streamx
- Investigate fast-glob HOT 2
- Lists only 16 or less files when a glob string including no globstar. HOT 15
- BUG: UNC paths aren't resolved correctly HOT 1
- Snyk High Vulnerability: through [email protected]
- Updating from v8.0.0 to v8.0.1 causes RangeError: Maximum call stack size exceeded HOT 11
- Gulp.dest fails to move files between filesystems in v5 HOT 1
- Gulp.src glob pattern fails in various edge situations HOT 3
- v5 becomes significantly slower if a lot of NPM packages are installed HOT 5
- Gulp v5.0.0. Problem via `src` usage with external `gulpfile.js` HOT 6
- Sourcing files from a folder that doesn't exist using a glob pattern gives a cryptic error instead of nothing happening HOT 6
- How can I use it with gulp? HOT 1
- Can't install glob-stream - ECONNRESET error HOT 1
- How to properly read chunks of all files content into a single stream? HOT 3
- npm audit returns errors. HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from glob-stream.