[Bug]: complexCamelCaseModels will break the routes about filament-nested-resources HOT 7 CLOSED

Hi, thanks a lot for the bug report! I'll try to work on a fix as soon as I can. You're also welcome to make a PR if you want.

from filament-nested-resources.

@lukas-frey nice work on the plugin, it is super helpful. Had a question about the route names. Looks like the parameters from the route slug are not being removed. Using the example from this issue, they appear like this

admin.projects.{projectRecord?}.project-sp-natures.{project sp natureRecord?}.building-blocks.create

when normally I believe they are like this

admin.projects.project-sp-natures.building-blocks.create

Just wondering if this was by design or if it might change in future releases.

from filament-nested-resources.

@acepoblete Great catch! It's not by design, I didn't really know it did that until now. Are you actually interacting directly with these slugs in your app?

I will fix it in the next release.

from filament-nested-resources.

I can confirm @niccolofavari 's report. My parent resource is named JobCampaign, which results in the route admin/job-campaigns/{job campaignRecord?}/child-resource/{record} and produces a 404.

I believe the root cause is using Filament's get_model_label helper in this package's get_model_route_parameter helper, which produces a space-separated version of the model class name. I assume that the Filament helper get_model_label is intended for UI/display labels, and not for route parameters. I'll look into possible fixes as well :-)

from filament-nested-resources.

@acepoblete Great catch! It's not by design, I didn't really know it did that until now. Are you actually interacting directly with these slugs in your app?

I will fix it in the next release.

I have a custom tab component for navigating between child resources. It's not very smart, so I have to manually generate the URLs for each tab. I noticed that route parameters when trying to figure out what route names to use for the child resources. I'll have a PR for this fix shortly.

moved this to issue #5

from filament-nested-resources.

🎉 This issue has been resolved in version 1.0.0-alpha.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

from filament-nested-resources.