Code Monkey home page Code Monkey logo

Comments (5)

thisisdano avatar thisisdano commented on June 7, 2024

I removed this because it was added significant build time, and I wasn't sure that pagination was helping. I guess the question is: what problem does pagination solve here?

I don't think it makes the information easier to navigate, and I don't think it has a performance benefit. But I'm happy to hear the case for it!

from digitalgov.gov.

ToniBonittoGSA avatar ToniBonittoGSA commented on June 7, 2024

Well, ideally, pages should not scroll "forever" but my main concern is that we now have a lot of broken links in our Search results.

I searched for podcast
https://find.digitalgov.gov/search?affiliate=digitalgov&query=podcast

Four of the 6 search result pages have links that go to Category and Sitemap pages, but they all show 404s now. Examples:
https://www.digitalgov.gov/category/content/page/21/
https://www.digitalgov.gov/sitemap/page/49/

Would it be quicker, easier to remove Category and Sitemap from Search results?
They'll still need pagination eventually, but can be done later and would reduce Search result 404s

from digitalgov.gov.

thisisdano avatar thisisdano commented on June 7, 2024

Well, ideally, pages should not scroll "forever"

I honestly don't know the right way on this. I'll need to see if there's any existing research, or any reason that pagination is better than no pagination.

we now have a lot of broken links in our Search results.

That's definitely a problem

Would it be quicker, easier to remove Category and Sitemap from Search results?

Definitely, I think. I don't feel like there's any good reason to get either of these in search results. Similarly Tag pages. I don't think you'd want to get search results for mobile that are, like, tag/mobile/page/1/, tag/mobile/page/2/, tag/mobile/page/3/, tag/mobile/page/4/, ad infinitum.

from digitalgov.gov.

ToniBonittoGSA avatar ToniBonittoGSA commented on June 7, 2024

Cool --
and tags (thankfully) were never in the Search results (we only accessed them via the links at the bottom of each post)... just Categories and Sitemap (I always thought those 2 should not be included in search results)

from digitalgov.gov.

jeremyzilar avatar jeremyzilar commented on June 7, 2024

This has been completed 🎉👾

from digitalgov.gov.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.