Nav on secondary page is wrong colors about code-gov-front-end HOT 6 CLOSED

@jlow81 , if this happens to you again, could you note exactly the order of progression through the pages. I am having a hard time duplicating and I think this bug has to do with the order at which you step through the pages. Thanks! :-)

from code-gov-front-end.

I've run into this bug again today. It's the same problem causing #48. I'm working on coming up with a fix now

from code-gov-front-end.

Issue is that connected-react-router is not registering changes to the window.location into the router in the Redux store when a user clicks a Link, only when we use the push function.

In other words, ConnectedRouter does not appear to be working. react-router and connected-react-router don't appear to work together: https://reacttraining.com/react-router/web/guides/redux-integration
I tried the workaround hear and it didn't work.

One solution may be to implement a shouldComponentUpdate and check properties of match object.

from code-gov-front-end.

Workaround mentioned above doesn't appear to work either:

I'll think on this and update the ticket when I have a next step. It will probably involved listening to events somehow or creating a custom CustomLink component that basically wraps around a Link component from the react-router library

from code-gov-front-end.

I tried doing this with this.props.location, which I believe is provided by react-router-dom and that didn't work. What's probably easiest is to just store the pathname in the state and check to see if that changes. Will try that and if that doesn't work, maybe work on wrapping Link and NavLink

from code-gov-front-end.

Fixed. Solution was hacky, but works.

from code-gov-front-end.