Code Monkey home page Code Monkey logo

Comments (6)

sienki-jenki avatar sienki-jenki commented on August 15, 2024

How did you find out about this error? There is a way to import fonts as a <link> instead of @import. Also, probably we don't need that many Poppins styles. But overall I would like to see some kind of error or information that indicates incorrect parsing.

from lightspeed-react.

tcriess avatar tcriess commented on August 15, 2024

Chromium's console log says
GET http://127.0.0.1/url(https://fonts.googleapis.com/css2?family=Poppins:ital,wght@0,100 net::ERR_ABORTED 404 (Not Found)
So, it seems that the parsing stops after the first semicolon in the url and the browser tries to import the relative path.

from lightspeed-react.

sienki-jenki avatar sienki-jenki commented on August 15, 2024

@tcriess Just for you I installed Chromium ver. 89.0.4387.0. GET request seems to be working fine, URL is parsed correctly and every font is fetched. Could you provide more information what are you exactly using?

from lightspeed-react.

tcriess avatar tcriess commented on August 15, 2024

I am on Chromium 87.0.4280.141 (snap) on Ubuntu. Files are served via nginx running in an lxc container, but that does not seem to be the issue here. As far as I can tell it really is the missing quotes. In firefox, it is parsed ok, no problem there.

from lightspeed-react.

sienki-jenki avatar sienki-jenki commented on August 15, 2024

Well, I can see that URL is missing quotes, but only after build. Somehow my Chromium, Chrome and Firefox are parsing this correctly anyway. I will take a closer look at this tomorrow.

from lightspeed-react.

tcriess avatar tcriess commented on August 15, 2024

#15 fixes it, thanks!

from lightspeed-react.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.