Comments (3)
This is happening on gruntwork.io & locally on master too, so I believe it hasn't been fixed in any of the more recent PR's
from gruntwork-io.github.io.
Tagging @zackproser @brikis98 to get your thoughts on this!
So after digging into this, me & @marinalimeira found out it's because of the "how it works" section. After pairing with @brikis98 we also realised it's because we were rendering an empty image tag with a set width. See fix PR here: https://github.com/gruntwork-io/gruntwork-io.github.io/compare/landing/patcher-fix-wider-page?expand=1.
Another last thing we noticed was that the gif expanding (the first one) has a reference to the renovate Github app. That's not easy to see, but once you know it, you know it :D
from gruntwork-io.github.io.
Tagging @zackproser @brikis98 to get your thoughts on this!
So after digging into this, me & @marinalimeira found out it's because of the "how it works" section. After pairing with @brikis98 we also realised it's because we were rendering an empty image tag with a set width. See fix PR here: https://github.com/gruntwork-io/gruntwork-io.github.io/compare/landing/patcher-fix-wider-page?expand=1.
Another last thing we noticed was that the gif expanding (the first one) has a reference to the renovate Github app. That's not easy to see, but once you know it, you know it :D
Thanks for spotting and fixing this @ina-stoyanova and @marinalimeira! I will re-create the gif now to remove the reference to renovate
.
from gruntwork-io.github.io.
Related Issues (20)
- Nav menu links are partially hidden when in collapsed state
- Alignment issue for eks tabs on landing page HOT 1
- Replace images on Patcher landing page with less blurry ones HOT 1
- Broken images on Patcher page
- Inconsistent text in Patcher pages
- Wide images in Patcher landing page break the flow a bit HOT 1
- Minor continuity issue with the "Use the UI" .gif on Patcher page
- Blurry images in Patcher How it Works page
- Authorize & Install Grunty (GitHub App) image on Patcher landing page is slightly blurry HOT 4
- Wrong thumbnail for social media sharing on all landing pages HOT 1
- CIS 1.4 deployment guide: Fix comments from PR #639
- CIS 1.4 migration guide: Fix comments from PR #512 HOT 1
- Remove Reference Architecture Walkthrough course from gruntwork.io/training HOT 1
- Should we add a docs site link to the footer? HOT 3
- Remove MongoDB from carousel HOT 1
- Remove references to MongoDB
- Broken Docker quick start
- Broken video on FAQ page HOT 6
- Bug on mobile
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gruntwork-io.github.io.