assertion next_bdp_ping_timer_handle kInvalid about grpc HOT 5 CLOSED

Looking at the code, I think the problem is the zero value for next_ping duration. In posix_engine.cc there is function called RunAfterInternal(). If the when duration is less than or equal to zero, the call back is run immediately and an invalid handle is returned. (Code which was added by AJ Heller 08-16-2023).

Perhaps a simple solution would be to ensure the duration is never zero.

Perhaps in finish_bdp_ping_locked() the following code could be added:

      #define MIN_PING_TIME 5 // ms

      t->event_engine->RunAfter(std::max(next_ping - grpc_core::Timestamp::Now(),
                                         grpc_core::Duration::Milliseconds(MIN_PING_TIME)), [t] {

from grpc.

I think we can just remove the assert, it's wrong. In the case where a RunAfter is immediate, the handle will be invalid since the callback will not be cancellable.

from grpc.

This should be fixed in #35953. If you'd like to test against the master branch, a nightly build should have this change tomorrow https://packages.grpc.io/

from grpc.

Thanks!

from grpc.

@pmoosman are you using the bigquery client library, or are you making gRPC calls directly?

from grpc.