Docs in GrpcChannelProperties not clear about `dns` scheme and have minor other problems about grpc-spring HOT 6 OPEN

PRs are welcome.

• scheme://location did not work as expected when I tested it back then (or wasn't implemented?).
• scheme:location didn't work either.
• schema vs scheme might be a typo
• too large code -> true
• scheme:[//authority]/path -> true
• host vs path -> it acts as a host/name so IMO that is more appropriate here
• {@code dns:/} -> maybe {@code dns:/some-address}
• this makes the official docs invalid -> please address that upstream

from grpc-spring.

• scheme://location did not work as expected when I tested it back then (or wasn't implemented?).

static://location does most certainly work. Two slashes won't work for example for dns though (and the template was given as to relevant for all of the cases, I guess)

• scheme:location didn't work either.

AFAIR it works for unix relative path scheme (+ the remark above).

The point is, the 3rd slash is actually a part of the path (it's the root of the path), so saying /path is kinda the source of the ambiguity here.

this makes the official docs invalid -> please address that upstream

yeah, I'll throw a bug report at the official repo on Monday as soon as I'm able to :D BTW I think I could get the initial version of the PR ready somewhere then as well.

from grpc-spring.

BTW,

host vs path -> it acts as a host/name so IMO that is more appropriate here

so should we call that "host" or "path" finally? ATM it says /path

Sorry, for being confusing.

I meant we should use path when speaking about unspecific URIs as per spec.
However when we refer specifically to the dns scheme, then we should call it host.

from grpc-spring.

• scheme://location did not work as expected when I tested it back then (or wasn't implemented?).

static://location does most certainly work. Two slashes won't work for example for dns though (and the template was given as to relevant for all of the cases, I guess)

• scheme:location didn't work either.

AFAIR it works for unix relative path scheme (+ the remark above).

I meant specifically the dns scheme.

from grpc-spring.

• scheme://location did not work as expected when I tested it back then (or wasn't implemented?).

static://location does most certainly work. Two slashes won't work for example for dns though (and the template was given as to relevant for all of the cases, I guess)

• scheme:location didn't work either.

AFAIR it works for unix relative path scheme (+ the remark above).

I meant specifically the dns scheme.

yeah, my point here is that currently the docs say "The target uri must be in the format: * {@code schema:[//[authority]][/path]}." etc. not about just the dns scheme, but in general, about all of them, that's why this format simply isn't right in the context it's used IMVHO. It's only a format valid for some of the schemes, yet the docs say "must" when speaking about all of them.

BTW,

host vs path -> it acts as a host/name so IMO that is more appropriate here

so should we call that "host" or "path" finally? ATM it says /path

from grpc-spring.

reported upstream as grpc/grpc#35539 and grpc/grpc-java#10824

from grpc-spring.