Code Monkey home page Code Monkey logo

Comments (1)

MikeKingdom avatar MikeKingdom commented on June 15, 2024

There are two problems here related to RangeSelectors in DataFilters.

  1. For complex, hierarchical property names that we support in forms like 'economy.GDP', DataForm's transformTouched specially treats RangeSelector values since it's looking for _range in the value object, but how it finds this in touched assumes only 1 level of property name. This is easy to fix.
  2. DataFilters decides whether to have a # of filters badge based on how many non-falsey things end up in touched as returned by transformTouched. But any property value in the form set back to it's initial value can be truthy if that initial value is something, especially true for RangeSelectors which will always have a value. Should DataFilters instead determine touched by comparing against initial/default values? Or is that something the badge calculation should do? I'm thinking the badge calc filter should compare against initial/default values for filters instead.

from grommet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.