Comments (4)
ShimiSun
commented on June 14, 2024
linking to grommet/hpe-design-system#1051
from grommet-theme-hpe.
taysea
commented on June 14, 2024
What I'm noticing here is that Select icon takes a color, which we have defined as text. With buttons, we have defined their disabled behavior to have color of text-weak: https://github.com/grommet/grommet-theme-hpe/blob/NEXT/src/js/index.js#L327, however, this color is not being applied to the icon in Select. Instead, it is being controlled by this line: https://github.com/grommet/grommet/blob/master/src/js/components/Select/Select.js#L188
What seems like the cleanest approach is that the user would be able to set select.disabled.icons.color in the theme. This would need to be added in grommet.
from grommet-theme-hpe.
taysea
commented on June 14, 2024
@LiveFreeAndRoam For this case, it seems like another case that the Select is not receiving disabled styling. Can you try the approach I wrote on this issue and confirm it solves this issue? We will add it to the theme if so.
from grommet-theme-hpe.
ShimiSun
commented on June 14, 2024
The issue is fixed on v2.0.0. feel free to reopen or file a new issue if needed.
from grommet-theme-hpe.
Related Issues (20)
- Update Form kind survey theme
- Stage "refreshed" theme version on NEXT HOT 5
- Brand refresh - FileInput should receive updated button styling HOT 1
- Brand Refresh - Write migration guide HOT 4
- Brand Refresh - Publish v5 HOT 2
- Calendar - fontSize is ignored HOT 4
- NameValueList loses responsiveness on resizing HOT 3
- DataTable - units are not an accessible color HOT 2
- Accordion - border colors with opacity result in inconsistent accordion borders
- Button badge alignment on Safari HOT 2
- Design Tokens - Build step to resolve token values HOT 1
- Tag - Update medium tag in HPE theme HOT 1
- How to change the button primary background color from green? HOT 4
- How to change the default font? HOT 3
- PageHeader doesn't properly handle xsmall breakpoint when responsive="true"
- Update Tag to use Close icon HOT 4
- Discussion - Update typography to use `rem`
- Add missing gradients
- Add `data.button.kind` to HPE theme
- Add readonly styling HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from grommet-theme-hpe.