Comments (23)
vadim9999
commented on June 12, 2024
3
@atherdon Please review header
from react-print-pdf.
atherdon
commented on June 12, 2024
1
in the end - we should have only one header component, that will accept
different options inside of it.
So, instead of having
- showcase project - HeaderShowcase
- antd-recipe project HeaderRecipe
- react-print0df Header
we should have only one component wrapper that will fit well for all of
those cases, so we'll be able to delete all of these old components that
have a similar logic
so your goal to have here only one component:
https://github.com/GroceriStar/antd-showcase-components/tree/master/src/components/Header
from react-print-pdf.
atherdon
commented on June 12, 2024
1
so, if i was you - i'll try to figure out the difference inside of code and try to make it for for all cases at the same time.
then i'll push new version at npm
then i'll install that latest version at all 3-4 repositories, that have header component and see if it works
from react-print-pdf.
atherdon
commented on June 12, 2024
1
i'm wroking on it. looks like it will be fixed soon. not ideal but - right now we don't have that eror. updating showcase and recipe-ntd with the same logic
from react-print-pdf.
vadim9999
commented on June 12, 2024
from react-print-pdf.
atherdon
commented on June 12, 2024
i'm on it.
Should i review it only at this repo or also at recipe-antd and gs/showcase as well?
from react-print-pdf.
vadim9999
commented on June 12, 2024
Review it at this repo. Now I will update at other recipe-antd and gs/showcase
from react-print-pdf.
atherdon
commented on June 12, 2024
code looks ok, but i have fetch issue at selector, can you take a look?
and buzz me when i'll need to check it at 2 other repos as well
…from react-print-pdf.
vadim9999
commented on June 12, 2024
Header using component Link from react-router-dom. If you will use header without Router you will get Error
from react-print-pdf.
vadim9999
commented on June 12, 2024
code looks ok, but i have fetch issue at selector, can you take a look?
it's in this repo?
from react-print-pdf.
atherdon
commented on June 12, 2024
yes, try to start it. maybe i did something wrong.
do you mean i should open not the first page? please elaborate your
previous message about router error
…from react-print-pdf.
vadim9999
commented on June 12, 2024
Header will be working with Router. Else you get this Error:
Error: Invariant failed: You should not use <Link> outside a <Router>
Because in Header we are using component Link that works in component BrowserRouter.
We can fix this replacing component Link by
from react-print-pdf.
atherdon
commented on June 12, 2024
ok, so how i can exactly see a working header?
should i open some sub-page, right?
aka `localhost/prf1` will work?
…from react-print-pdf.
vadim9999
commented on June 12, 2024
you can type localhost:3000/
In react-print-pdf I should add in BrowserRouter header that it will appear on all paths
from react-print-pdf.
vadim9999
commented on June 12, 2024
In recipe-ant I also add it to router
from react-print-pdf.
atherdon
commented on June 12, 2024
should i run react-print-pdf locally again?
…from react-print-pdf.
vadim9999
commented on June 12, 2024
yes
from react-print-pdf.
atherdon
commented on June 12, 2024
still got an error. maybe i should downgrade fetch? it maybe will help to my local version
from react-print-pdf.
vadim9999
commented on June 12, 2024
yes, it's a problem with fetch. I tried to downgrade but it's not a success.
Now you can test showcase.
from react-print-pdf.
vadim9999
commented on June 12, 2024
Summary
- In all 3 projects: react-print-pdf, recipe-antd, showcase are Header that will appear in all paths(/, padf1, groceries).
- Fetch in this 3 projects doesn't work. Need to fix it.
- After we will fix fetch we should add a listener on each button that is in Header. Now Header It's just buttons that nothing doing.
from react-print-pdf.
atherdon
commented on June 12, 2024
ok, got it, then fixing fetch is my goal in order to make our react
frontend work.
i also exploring how to make an advanced travis setup, so at fetch we can
not just build it and run tests, but also can install a clean react app
separately, add fetch there and try to run it in order to see errors like
this
from react-print-pdf.
vadim9999
commented on June 12, 2024
Do you mean add here travic ci?
from react-print-pdf.
atherdon
commented on June 12, 2024
it's more like add at travis ci +200% of complexity but for developers it
will work as magic
from react-print-pdf.
Related Issues (9)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-print-pdf.