Keep alive connection about jesque HOT 5 CLOSED

Hmmm, it looks like a bug to me. It looks like I introduced it 2.5 years ago in 19989fb !

from jesque.

My suggestion would be to try changing the keep-alive runner to have the following:

if (!JedisUtils.ensureJedisConnection(jedis)) {
    authenticateAndSelectDB();
}

instead of:

ensureJedisConnection();

If that works, I'll commit a fix.

from jesque.

Yep that would be fine but maybe you could simply change the following in the constructor on line https://github.com/gresrun/jesque/blob/master/src/main/java/net/greghaines/jesque/client/ClientImpl.java#L92

  this.checkConnectionBeforeUse = true;

This would ensure that the other constructor works as expected as well

from jesque.

The whole reason for the second constructor is that the reconnection logic happens on a separate thread and not on the thread performing the client work. by setting this.checkConnectionBeforeUse = false, we prevent the client thread from doing any work in ensureJedisConnection(). The bug was that the reconnection thread wasn't doing any work, either!

from jesque.

Ah I see! Then I think your suggestion will work fine.

from jesque.