Comments (7)
Sounds correct to me. Would you mind putting a pull request together?
from jesque.
Michael, I looked over the issue and I believe the simplest answer is not to even call recoverFromException() in the case of an interrupt for shutdown. Can you review the commit above to see if you agree?
The branch is issue-20.
from jesque.
There might be some value to still handle the exception in the case of
an unexpected interruption when it is not in the shutdown state. I
would expect to get a log statement in that case.
On May 11, 2012, at 7:23 PM, Greg Haines
[email protected]
wrote:
Michael, I looked over the issue and I believe the simplest answer is not to even call recoverFromException() in the case of an interrupt for shutdown. Can you review the commit above to see if you agree?
The branch is issue-20.
Reply to this email directly or view it on GitHub:
#20 (comment)
from jesque.
The logic in the commit will only discard InterruptedExceptions while in the SHUTDOWN
state:
catch (InterruptedException ie)
{
if (!isShutdown())
{
recoverFromException(curQueue, ie);
}
}
Which covers the case you mentioned, if I understood you correctly.
from jesque.
Sorry, I have limited connectivity through Monday, but I did just jump on my laptop. I missed the commit earlier when I replied on my phone. I think it looks good, it would address both the situation of an expected InterruptedException when calling worker.end(true)
and handling and unexpected InterrtuptedException in other cases. Thanks.
from jesque.
Merged into master.
from jesque.
This fix is in v1.2.0, which I just cut this evening.
from jesque.
Related Issues (20)
- java.net.UnknownHostException thrown when `ip-#-#-#-#` pattern has no reverse lookup HOT 2
- No worker running when facing `Terminating in response to exception`
- jackson 2.9 incompatibility
- jackson databind 2.9 includes a breaking change HOT 5
- successful job is re-enqueued during shutdown HOT 1
- Worker queue in redis not reset when restarting?
- client.enqueue() error `java.lang.NoSuchMethodError: com.fasterxml.jackson.databind.DeserializationConfig.with` HOT 1
- Throw JedisDataException when enqueue a job HOT 1
- Requesting new public release. HOT 1
- Version 2.1.3 breaks API compatibility from 2.1.2 HOT 1
- why does jesque not use namespace as prefix for recurring jobs? HOT 2
- RESET_TO_HIGHEST_PRIORITY Strategy not work for recurring job
- Implement a way to set FailQueueStrategy on WorkerImplFactory
- Jedis 3.X compatibility HOT 9
- NoSuchConstructorException HOT 1
- 通过jesque的延时任务实现支持cron表达式的调度任务 HOT 1
- Redis Cluster Issue
- ETA on current master release HOT 1
- Job moved from inflight queue to comma-joined queue on worker shutdown in RESET_TO_HIGHEST_PRIORITY strategy.
- Worker existing on uncaught exception after 10 minutes of no connection
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jesque.