Change DefaultWorkerExceptionHandler? about jesque HOT 7 CLOSED

Sounds correct to me. Would you mind putting a pull request together?

from jesque.

Michael, I looked over the issue and I believe the simplest answer is not to even call recoverFromException() in the case of an interrupt for shutdown. Can you review the commit above to see if you agree?

The branch is issue-20.

from jesque.

There might be some value to still handle the exception in the case of
an unexpected interruption when it is not in the shutdown state. I
would expect to get a log statement in that case.

On May 11, 2012, at 7:23 PM, Greg Haines
[email protected]
wrote:

Michael, I looked over the issue and I believe the simplest answer is not to even call recoverFromException() in the case of an interrupt for shutdown. Can you review the commit above to see if you agree?

The branch is issue-20.

---

Reply to this email directly or view it on GitHub:
#20 (comment)

from jesque.

The logic in the commit will only discard InterruptedExceptions while in the SHUTDOWN state:

catch (InterruptedException ie)
{
    if (!isShutdown())
    {
        recoverFromException(curQueue, ie);
    }
}

Which covers the case you mentioned, if I understood you correctly.

from jesque.

Sorry, I have limited connectivity through Monday, but I did just jump on my laptop. I missed the commit earlier when I replied on my phone. I think it looks good, it would address both the situation of an expected InterruptedException when calling worker.end(true) and handling and unexpected InterrtuptedException in other cases. Thanks.

from jesque.

Merged into master.

from jesque.

This fix is in v1.2.0, which I just cut this evening.

from jesque.