Code Monkey home page Code Monkey logo

Comments (5)

evenyag avatar evenyag commented on August 26, 2024

We may also need to move the serialization of Vector to DataType, so we could serialize the elements based on vector's logical type.

from greptimedb.

waynexia avatar waynexia commented on August 26, 2024

I suggest changing the parameter Primitive of PrimitiveVector to LogicalType (or another naming). With a type parameter PhysicalType. Just like this in arrow - ArrowPrimitiveType and type parameter Native.

from greptimedb.

tisonkun avatar tisonkun commented on August 26, 2024
pub struct PrimitiveVector<T: LogicalPrimitiveType> {
    array: PrimitiveArray<T::ArrowPrimitive>,
}

This is implemented now? @v0y4g3r @waynexia

from greptimedb.

evenyag avatar evenyag commented on August 26, 2024

This is related to the arrow2 crate, I guess we can close this issue now.

from greptimedb.

tisonkun avatar tisonkun commented on August 26, 2024

No longer relevant.

from greptimedb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.