Code Monkey home page Code Monkey logo

Comments (3)

greg7mdp2 avatar greg7mdp2 commented on July 23, 2024

Yes, your findings are correct, however:

  1. your test program uses a very specific sequence of keys (all consecutive integers)
  2. Google sparsehash just uses the integer key as the hash value (pass-through hashing)

This makes the insertion very fast, as there are no collisions. However, it makes finding that a key is not present in the set extremely slow. For that reason, I have chosen to not use pass-through hashing, even though it can look better in simple tests.

To see for yourself, you can add the following lines in your test program, after the insertion:

  size_t count = 0;
  for (int i = 0; i < n; i++)
      if (s.find(rand()) != s.end())
          ++count;
  printf("count = %zu\n", count);

This will demonstrate that the pass-through hashing, which looks very good on insertion-only tests, is probably not advisable in general.

from sparsepp.

greg7mdp avatar greg7mdp commented on July 23, 2024

I don't advise to use pass-through hashing, but it can easily be done with sparsepp as well. For example define:

struct Hash32 {
   size_t operator()(uint32_t k) const { return k; }
};

and your set as: spp::sparse_hash_set<int, Hash32> s;

You will see that the insertion is now faster than with Google's sparse_hash_set, and that the memory usage is reduced to ~1.2GB, still a little bit more than Google's version.

However the lookup of non-present keys will be very slow, so it is probably not a very good idea.

from sparsepp.

greg7mdp avatar greg7mdp commented on July 23, 2024

Closing the issue, please reopen is you still have some questions.

from sparsepp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.