Comments (4)
Hi, thanks for getting in touch!
allow managing of all stages
autohooks was always designed with supporting all stages in mind. We just didn't needed other stages beside pre-commit yet. Thus I am of course open to all kind of changes in this regard.
Your items are all valid and sophisticated. Just my short thoughts about it. The configured plugins should define which stages are used by default and the user should get the hidden power to override the behavior. From reading your items it seems you have something similar in mind.
Feel free to create PRs. Please make the PRs as small as possible. If you add smaller PRs it is much more likely that we can integrate them quickly without much effort. Reviewing longer PRs that touch several areas and change behavior will take some time because this is only a side project and hasn't high priority.
from autohooks.
hey there, thanks for the reply.
I'm just looking at the code trying to figure out the best approach to get this working.
I totally agree with small PRs, but looking at the code and how the pre-commit
-notion runs all through the codebase (in naming of variables, functions, classes) the proper approach seems to get that part hook-agnostic first (eg inautohooks/hooks.py
renaming PreCommitHook
to GitHook
and so on)
but that feels hella invasive.
I'll give it a shot to get the wording right first before changing any functionality to see how big a change that would end up being.
from autohooks.
Hey @betaboon have you made any progress on this? If not, I might take a shot at it. I don't want to duplicate work, though.
from autohooks.
Nope, ended up doing got due to lack of feedback in this issue
from autohooks.
Related Issues (16)
- autohooks.utils.GitError: Git command '['git', '-C', '...', 'rev-parse', '--git-dir']' returned non-zero exit status 128 HOT 15
- commit fails on Windows with Python encoding error HOT 7
- (Feature Request) Mandatory hooks / less graceful ImportError failure HOT 7
- `packaging` requirement HOT 5
- Supported mypy plugin HOT 2
- Pipenv mode is broken by the --split-string (-S) argument of env in the shebang HOT 9
- Windows Support? HOT 8
- Output overwritten by carriage return HOT 9
- Enable system wide autohooks called from git commit in a virtual environment (eg. to support PyCharm) HOT 7
- Terminal class fails to determine witdth in NeoVim HOT 4
- Support ruff HOT 6
- Request to add ruff HOT 5
- Poetry Hooks HOT 1
- When creating a custom hook in .authooks directory I get: No module named 'autohooks.plugin.flake8' HOT 2
- Windows Problem HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from autohooks.