Code Monkey home page Code Monkey logo

Comments (4)

bjoernricks avatar bjoernricks commented on May 20, 2024

Hi, thanks for getting in touch!

allow managing of all stages

autohooks was always designed with supporting all stages in mind. We just didn't needed other stages beside pre-commit yet. Thus I am of course open to all kind of changes in this regard.

Your items are all valid and sophisticated. Just my short thoughts about it. The configured plugins should define which stages are used by default and the user should get the hidden power to override the behavior. From reading your items it seems you have something similar in mind.

Feel free to create PRs. Please make the PRs as small as possible. If you add smaller PRs it is much more likely that we can integrate them quickly without much effort. Reviewing longer PRs that touch several areas and change behavior will take some time because this is only a side project and hasn't high priority.

from autohooks.

betaboon avatar betaboon commented on May 20, 2024

hey there, thanks for the reply.

I'm just looking at the code trying to figure out the best approach to get this working.

I totally agree with small PRs, but looking at the code and how the pre-commit-notion runs all through the codebase (in naming of variables, functions, classes) the proper approach seems to get that part hook-agnostic first (eg inautohooks/hooks.py renaming PreCommitHook to GitHookand so on)

but that feels hella invasive.
I'll give it a shot to get the wording right first before changing any functionality to see how big a change that would end up being.

from autohooks.

grahamtt avatar grahamtt commented on May 20, 2024

Hey @betaboon have you made any progress on this? If not, I might take a shot at it. I don't want to duplicate work, though.

from autohooks.

betaboon avatar betaboon commented on May 20, 2024

Nope, ended up doing got due to lack of feedback in this issue

from autohooks.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.