Column (and Stack) won't expand to it's content in 1.1.5/6 about stacks HOT 5 CLOSED

Hi,

So the first screenshot is how Column behaves with 1.1.5/6 without adding flex:1 and the second one is the correct behaviour.

Before it was working without the need to add flex in style ( not sure it was 1.1.4 or 0.9.6 though 😅

I will try to create a simpler example

from stacks.

@mobily ok, added the example : https://github.com/rborn/stacks_box_style_issues/blob/master/src/App.js#L32

set in package.json 0.9.4 - ✅

set in package.json 1.1.6 - 💥

change to <Column width={"content"} style={{ flex: 1 }}> and works again (with 1.1.6)

Thanks a lot 😻

from stacks.

@mobily thanks a lot, seems to work ( at least in the example) will report back in case I found anything 🥰

from stacks.

@rborn I'm looking at those screenshots, and I'm not sure what's the issue here? 😅 there weren't any changes in Columns/Stack in the last two versions v1.1.5/6, are you sure the problem isn't on your end? could you provide a basic example with this issue? :)

from stacks.

since both implementations (v0.9.x and v1.x) are completely different, the column won't adjust its height against other columns automatically in v1.x :)

I have added the height prop (the responsive format) to the Column component, so you can use it instead of flex: 1.

there's an example in the docs as well: https://mobily.github.io/stacks/docs/components/column/#examples

and in your example, you may want to add height="fluid" to see how it's working:
https://github.com/rborn/stacks_box_style_issues/blob/b35aae31c6a803c38892fdf89b99ea6ba53c1238/src/App.js#L32

🚢 shipped in v1.1.7!

from stacks.