Code Monkey home page Code Monkey logo

Comments (4)

sogko avatar sogko commented on July 21, 2024

Thanks @EmergentBehavior for bringing this up 👍🏻

Too bad someone else already squatted on https://github.com/go-graphql/ for a long time now; we could have gotten gopkg.in/graphql.v0.

I was too late and only managed to snag github.com/graphql-go.
So we ended up with gopkg.in/graphql-go/graphql.v0, which isn't that bad lol


There are several things we can discuss to kick things off:

Semver
  • We should at least agree on semver for versioning (e.g. v1.2.3), right?
Branch vs tags?
Internal import paths

We can encourage users to use the versioned package import e.g gopkg.in/graphql-go/graphql.v1 in the README and examples, but internally for our code base, do we want to use gopkg.in/graphql-go/graphql.v1 or github.com/graphql-go/graphql?

Again, graceful and mgo shows two different approaches.

Cheers!

from graphql.

EmergentBehavior avatar EmergentBehavior commented on July 21, 2024

Strongly recommend going with semver. and have always preferred using branches over tags, but of course we should see what everyone is comfortable with.

Internally, I think it may make more sense to use the github.com path. With gopkg.in, v0 will point to master, but once there is a major version pushed, e.g. v1, it will always point to the latest semver of that branch (e.g. 1.1.2, 1.9, etc.). This could cause confusion during internal development.

from graphql.

switchtrue avatar switchtrue commented on July 21, 2024

Its probably also worthwhile considering how to clearly show which versions of graphql-go track against versions of the graphql spec.

from graphql.

chris-ramon avatar chris-ramon commented on July 21, 2024

@mleonard87 thanks for bringing it up! — let's have the graphql-js version parity on each release's description; closing this one and let's continue the conversation on new issues.

from graphql.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.