Comments (10)
Quick update:
I've created an experimental branch for resolving fields concurrently:
https://github.com/sogko/graphql/tree/sogko/experiment-parallel-resolve
It is currently based on the v0.4.18
branch (pending merge, being reviewed).
It satisfies current set of unit tests (which is great), but still need to spend some time to discover edge cases that I might have missed.
Cheers!
/cc @chris-ramon
from graphql.
Just for the record this issue was closed since we support concurrent resolvers, an example was added on how to achieve it: https://github.com/graphql-go/graphql/blob/master/examples/concurrent-resolvers/main.go — thanks a lot for the great feedback! 👍
from graphql.
It seems both methods are the exact same thing.
Maybe that would explain why I get huge perf issues ?
Could somebody confirm/infirm ?
from graphql.
@bigblind You are right, the executor in graphql-go
currently does not take full advantage of being able to resolve fields concurrently. The library is still at its infancy and and was more concerned about getting it right, conforming to specs, over optimising for performance at first. PR is definitely welcomed 👍🏻
@solher Would like to share the issues that you are facing? (May suggest opening a separate issue?)
from graphql.
@sogko Is it not in the specs how parallelization should work with queries? It's important that this be implemented properly. From what I understand is that query fields should be parallelized; however, mutation fields should not.
from graphql.
@bbuck The spec does not really specify if you should / should not execute a request concurrently / parallelise it. It just dictates that the order of evaluation. (Relevant section:
http://facebook.github.io/graphql/#sec-Serial-execution)
So you can, in effect, choose to implement the executor to run a query and even a mutation concurrently, as long as you can guarantee that the evaluation order for a mutation is done serially as the user has specified.
For non-mutation (i.e. normal query), the order of evaluation can be non-deterministic (which allows for concurrent evaluation easily). (http://facebook.github.io/graphql/#sec-Normal-evaluation)
So, right now, the library does not evaluate fields concurrently for either query and mutation, but it conforms to the spec re: evaluation order.
Relevant test for serial evaluation for mutation:
Line 122 in 344abcc
Cheers!
from graphql.
@sogko Nothing really complicated here. When I find a list of 1000 nodes and their associated nodes, 1000 DB queries of 1ms are executed non concurrently so I get the result in 1 sec where I get it in 10 ms with the same rest app haha.
However, I'm still surprised that a simple "Hello world" on a root query takes an average of 5ms when a simple rest return would do it in 100 microsec. I obviously get that graphql adds a ton of logic and that it's perfectly normal to have an overhead but I would not expect it to be more than 10 times slower.
Is that only the amount of reflection that must be used that slows that much everything down ?
from graphql.
Any news ? 👍
from graphql.
Requesting reviews/comments for PR #132 which implements a concurrent field resolver.
(It is based off the 0.5.0 PR, so there will be a lot of unrelated commits. I've isolated the relevant commits on the description).
Any help is appreciated!
Cheers!
from graphql.
@sogko - This is in relation to this and #123
I haven't done anything in the way of a code review but I've upgraded a system we've got to 0.4.8 and then to your sogko/experiment-parallel-resolve branch. There were no code changes required and everything worked great!
We are currently in the process of testing three identical GraphQL backends - Go, Java and Node - to determine what we want to use going forwards. As part of this we are running load tests.
Our app spends a lot of time communicating with a third party server over HTTP (offsite). We make an initial call to it to get a list of patients and then for each patient we need to do an additional lookup via the HTTP call to resolve a particular ID field. Given that there is a resolve fired for each patient in a list to get this ID which in turn makes an HTTP request I was expecting to see big wins with the use of parallel resolvers. However, I am not seeing much difference in regards to performance here.
The project I am using is open source and can be found here.
The query I am using is below - this returns a list of patients and each patient has a resolve function that makes an HTTP call (click to see the code) to get the ehrId
field.
POST
{
patients {
id,
firstname,
surname,
address,
phone,
dob,
email,
gender,
allergies {
name,
date
},
ehrId,
surgical
}
}
Go - GraphQL-0.4.8
mike@Michaels-MacBook-Pro-2 ~/g/wrk> ./wrk -t12 -c400 -d150s -s gql_t2.lua --timeout 30s "http://10.100.13.235:3001/graphql"
Running 2m test @ http://10.100.13.235:3001/graphql
12 threads and 400 connections
Thread Stats Avg Stdev Max +/- Stdev
Latency 15.96s 1.35s 21.54s 67.48%
Req/Sec 5.63 6.94 60.00 91.25%
2165 requests in 2.50m, 14.35MB read
Socket errors: connect 155, read 0, write 0, timeout 0
Requests/sec: 14.43
Transfer/sec: 97.96KB
Go - GraphQL-0.5.0
mike@Michaels-MacBook-Pro-2 ~/g/wrk> ./wrk -t12 -c400 -d150s -s gql_t2.lua --timeout 30s "http://10.100.13.235:3001/graphql"
Running 2m test @ http://10.100.13.235:3001/graphql
12 threads and 400 connections
Thread Stats Avg Stdev Max +/- Stdev
Latency 14.43s 2.55s 23.73s 62.76%
Req/Sec 3.57 4.45 39.00 81.05%
1960 requests in 2.50m, 12.99MB read
Socket errors: connect 155, read 183, write 0, timeout 0
Requests/sec: 13.06
Transfer/sec: 88.69KB
Go - GraphQL-0.5.0 (with Parallel Resolve)
mike@Michaels-MacBook-Pro-2 ~/g/wrk> ./wrk -t12 -c400 -d150s -s gql_t2.lua --timeout 30s "http://10.100.13.235:3001/graphql"
Running 2m test @ http://10.100.13.235:3001/graphql
12 threads and 400 connections
Thread Stats Avg Stdev Max +/- Stdev
Latency 16.02s 1.97s 24.11s 67.78%
Req/Sec 3.91 4.91 49.00 78.26%
2151 requests in 2.50m, 14.26MB read
Socket errors: connect 155, read 0, write 0, timeout 0
Requests/sec: 14.34
Transfer/sec: 97.35KB
By the way - these times still beat the Java implementation (16.49s with a lot of errors being generated) and the Node implementation (21.20s)
from graphql.
Related Issues (20)
- Create graphql schema from string HOT 3
- The code generator does not take into account naming conflicts HOT 1
- How to take metro in graphql out of the solve?
- Is this project still mantained? HOT 2
- New release?
- Potential goroutine leak in TestContextDeadline HOT 1
- Enums with trailing white space cause error.
- Playground
- make union input type ? it just have output union type
- With fiber HOT 1
- Printing GraphQL documents is slow HOT 1
- Bug with underscore and same name in keys from json response
- MongoDB _id field
- Printer returns invalid SDL if Block String comment contains double-quote
- When using custom scalar types, it's crucial to provide error feedback to users when issues arise with their submitted data. However, triggering exceptions within the ParseValue and ParseLiteral methods can lead to program crashes when using the graphql.Do method. This prevents the necessary error messages from being delivered to users.
- String type no longer recongised HOT 1
- Is it possible to go from `*graphql.Schema` to an ast node? HOT 1
- Error handling HOT 1
- Disabling Field Suggestions
- Is possible to typing typeConfig of graphql.Object after Object done.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from graphql.