Code Monkey home page Code Monkey logo

Comments (8)

joemcbride avatar joemcbride commented on July 18, 2024 1

Once the build completes on the master branch I can push the nuget package to nuget.org. After I push it there it usually takes 10-15 minutes for nuget.org to index it.

from authorization.

joemcbride avatar joemcbride commented on July 18, 2024 1

And ... I just remembered I didn't bump the version. So doing that and running another master build.

from authorization.

joemcbride avatar joemcbride commented on July 18, 2024

I would expect that to fail. I think I know what the issue is:

CheckAuth(fieldAst, fieldDef.ResolvedType, userContext, context, operationType);

fieldDef.ResolvedType should be getting the "root" GraphType here instead of just passing ResovledType, since that ResolvedType could be a NonNullGraphType<T> or ListGraphType<T>.

from authorization.

aaronjedwards avatar aaronjedwards commented on July 18, 2024

I was able to work around it for now by adding AuthorizeWith(...) to the field of the query directly. Would you consider this a fairly simple bug to fix? If so, I can take a crack at it.

from authorization.

joemcbride avatar joemcbride commented on July 18, 2024

@aaronjedwards It was fairly simple - pushed up #37 to fix it.

from authorization.

aaronjedwards avatar aaronjedwards commented on July 18, 2024

@joemcbride Awesome! Thanks for the quick turn around! I ask only because I don't have any insight into the matter, but how quickly can a simple bug fix like this get pushed through to the nuget package?

from authorization.

joemcbride avatar joemcbride commented on July 18, 2024

Its published, just need to wait for indexing.

https://www.nuget.org/packages/GraphQL.Authorization/2.1.29

from authorization.

aaronjedwards avatar aaronjedwards commented on July 18, 2024

@joemcbride Thanks again for the quick response. Ive got the latest package and it is working as intended!

from authorization.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.