Getting error "Default resolvers at the root level are not supported" following the custom subscriptions guide about operation-hooks HOT 8 CLOSED

Fixed in v1 👍

from operation-hooks.

I think I got it working, this is either a workaround or it should be in the documentation:

So I added a very simply resolver for the subscription:

    resolvers: {
      CommunityFeedItemCommentSubscriptionPayload: {
        async communityFeedItemComment(...args) {
          return require('./resolver').default(sql, ...args); // eslint-disable-line global-require
        },
      },
      Subscription: {
        communityFeedItemCommentAdded: (event) => ({ event }),
      },
    },

The event needs to get passed through so we have access the to the subject in the Payload resolver.

After that, everything seems to connect and work properly. Look aheads work, the query builder effectively does the look ahead and the resulting sql executed/produced seems accurate (based on looking at the query logs and debugging.

from operation-hooks.

@parris Can you confirm the order in which you're loading the pubsub and operationhooks plugins? I think you have to load pubsub first, then operation hooks.

from operation-hooks.

@benjie ahh - maybe that's it const pluginHook = makePluginHook([OperationHooks, PgPubsub, GraphilePro]);

from operation-hooks.

I was following the order found here https://www.graphile.org/postgraphile/plugins/ if I recall correctly. Perhaps the doc should get modified?

from operation-hooks.

@parris Can you confirm if this solved the issue? If so, a mod to the doc would be welcome 👍

from operation-hooks.

@benjie - I had a chance to look into this. Changing the order of the hooks does not impact this. In a fresh project (not using any other libraries between postgraphile and the codebase), and using mutations instead of subscriptions I've found the same thing to occur.

Example:

makeExtendSchemaPlugin(({ pgSql: sql }) => ({
    typeDefs: gql`
      type AuthenticationDetails {
        person: Person!
        jwtToken: String!
      }
      type RegisterPayload {
        authenticationDetails: AuthenticationDetails!
      }
    `,
     resolvers: {
      RegisterPayload: {
        async authenticationDetails(...args) {
          return resolver.registerPerson(sql, ...args);
        },
      },
    },
  },
} as ExtensionDefinition)),

This will throw Error: Default resolver found for field Mutation.registerPerson; default resolvers at the root level are not supported by operation-hooks

However, even doing something as simple as the following resolves the issue.

Mutation: {
   registerPerson: () => ({}),
}

from operation-hooks.

My guess is that things are running out of phase - operation hooks is trying to mod the resolver before it’s added by makeExtendSchemaPlugin. I’m not sure what we can do about this in v4.

from operation-hooks.