Comment out `export *` statements about ts2gas HOT 7 CLOSED

@grant , can you please explain why __export() should be also commented?
In my case __export() apears only after translation. Are there cases there it can be used before translation?
I added commenting of only export ... from ... and it works fine

v--TS--v
export * from 'file'
–––
var exports = exports || {};
var module = module || { exports: exports };
// export * from 'file'
 ^--GS--^

from ts2gas.

@pozhidaevak I'm really not sure what the case would be. __export is not valid in Apps Script of course.

Can you provide example expected INPUT and OUTPUT code?

from ts2gas.

@grant It is kind of follow up of this issue
On that issue, you suggested to comment __export but __export is actually in the OUTPUT when export is in INPUT. So I don't see why __export should be commented... I think there is no use case for __export be in the input. But I'm new to js so I may be wrong...
Both input and output are presented in original issue

from ts2gas.

So ts2gas work like:

• Take ts
• Transpile to gs
• Add this line to fix export errors:

var exports = exports || {};
var module = module || { exports: exports };

I think we may need to additionally test that export * transpiling works.

• Add some tests
• Add any necessary transforms.

from ts2gas.

@grant , I thought you were ok with me just commenting out export * in input for ts2gas.
Here is how it looks:

v--TS--v
export * from 'file'
–––
var exports = exports || {};
var module = module || { exports: exports };
function __export(m) {
    for (var p in m) if (!exports.hasOwnProperty(p)) exports[p] = m[p];
}

__export(require("file"));
 ^--GS--^

the result is not valid due to require()

so I want to make it look like

v--TS--v
export * from 'file'
–––
var exports = exports || {};
var module = module || { exports: exports };
// export * from 'file'
 ^--GS--^

from ts2gas.

@pozhidaevak, Yes, commenting export * before transpiling sounds good. I haven't tried it.

from ts2gas.

Published with ca542f2.

from ts2gas.