Comments (5)
Did a bit of digging on this. It looks like requests
version 2.25.0
and later supports urllib3
version 1.26
. Forking and modifying the requirements.txt
to requests
version 2.25.0
seems to resolve the issue. This requirement could be loosened to prevent this from happening in future, or it could simply be bumped.
What tests would be sufficient to verify this as a fix? Upload some packages?
from jamf-upload.
I'm sure the requirements can be looser. I wonder if setting all the requirements to >=
would suffice?
certifi>=2020.6.20
chardet>=3.0.4
idna>=2.10
requests>=2.24.0
requests-toolbelt>=0.9.1
six>=1.15.0
urllib3>=1.26.5
Depending on what parts of the project you are using, you may not need requests
at all...
from jamf-upload.
For my purposes, requests
is never used, which is why I have not yet created a PR. I will set requirements.txt
to the version you've proposed and do some testing with my workflow, but I wouldn't be surprised if it works fine for me but is a headache for someone else.
from jamf-upload.
Initial testing with another fresh venv
worked fine. The dependency resolver installed a bunch of newer versions of each package. I'll let you know how it goes in my pipeline.
(jamf_upload) % python3 -m pip install -r jamf-upload/requirements.txt
Collecting certifi>=2020.6.20
Using cached certifi-2021.10.8-py2.py3-none-any.whl (149 kB)
Collecting chardet>=3.0.4
Using cached chardet-4.0.0-py2.py3-none-any.whl (178 kB)
Collecting idna>=2.10
Using cached idna-3.3-py3-none-any.whl (61 kB)
Collecting requests>=2.24.0
Using cached requests-2.26.0-py2.py3-none-any.whl (62 kB)
Collecting requests-toolbelt>=0.9.1
Using cached requests_toolbelt-0.9.1-py2.py3-none-any.whl (54 kB)
Collecting six>=1.15.0
Using cached six-1.16.0-py2.py3-none-any.whl (11 kB)
Collecting urllib3>=1.26.5
Using cached urllib3-1.26.7-py2.py3-none-any.whl (138 kB)
Collecting charset-normalizer~=2.0.0
Using cached charset_normalizer-2.0.7-py3-none-any.whl (38 kB)
Installing collected packages: urllib3, idna, charset-normalizer, certifi, requests, six, requests-toolbelt, chardet
Successfully installed certifi-2021.10.8 chardet-4.0.0 charset-normalizer-2.0.7 idna-3.3 requests-2.26.0 requests-toolbelt-0.9.1 six-1.16.0 urllib3-1.26.7
from jamf-upload.
I changed the requirements as described above.
from jamf-upload.
Related Issues (20)
- JCDS mode: upload working, but policy can't find package HOT 13
- Test mode for JamfPackageCleaner? HOT 2
- Jamf Uploader Feature request: Optionally disable XML escaping for template variable substitution HOT 8
- READMEs missing some input variables HOT 1
- Feature request: Alternative version string input for JamfPatchUploader HOT 1
- Feature Request: Allow Autopkg Processors to extend curl options HOT 7
- Feature Request: add option to JamfPackageCleaner to skip and report if package is in use
- JamfUploaderTeamsNotifier category is empty HOT 1
- ComputerProfileUploader fails with integer key values
- API Client authentication not working HOT 1
- /Volumes is being added to a DP path that is using file://
- JamfRecipeMaker throwing error
- Package metadata creation fails HOT 1
- [Errno 2] No such file or directory: '/Volumes/JAMFShare/Packages/xxxxx.pkg using Multi DP HOT 2
- Feature Request: Allow uploading .zip files HOT 5
- upload of larger pkgs (> 1GB) fails with jamf uploader HOT 6
- No Token Found HOT 1
- create multiple policies with JamfPolicyUploader HOT 4
- Feature Request: Allow pkg name and display name to be different in JamfPackageUploader HOT 1
- Feature request: Support for new Failover URLs HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jamf-upload.