Add x-disable-provenance header to allow alert rules to be edited from the UI about grafana-client HOT 7 CLOSED

Hi again,

I tested on PUT operation and I get the error I mentioned, the error only happens when there is a rule already created without the header and we try to update it.

All right. I see, that makes sense. With the new improvements from #53, you will be able to control sending the header on your own behalf, by using the disable_provenance argument on the methods create_alertrule and update_alertrule.

The improvement has been released with grafana-client 3.4.0. Feedback is very much appreciated.

With kind regards,
Andreas.

from grafana-client.

Hi Johan Sebastian,

that's a very good suggestion, thank you. Are you sure the header should not be attached to the PUT request as well?

Citing the post...

We are enabling a workaround within the Provisioning API to do it by adding the x-disable-provenance header to the following requests:

POST /api/v1/provisioning/alert-rules
PUT /api/v1/provisioning/alert-rules/{UID}

... makes me think the header should be attached to both types of requests, no?

With kind regards,
Andreas.

from grafana-client.

I've just submitted #53, following your suggestion. Do you agree with the implementation?

from grafana-client.

Hi @amotl,

Sorry for the delay, I tested on PUT operation and I get the error I mentioned, the error only happens when there is a rule already created without the header and we try to update it.

This is the only consideration!

from grafana-client.

Hi @jyepesr1,

have you been able to test the feature successfully?

With kind regards,
Andreas.

from grafana-client.

Hi @amotl ,

I was able to test it out successfully. It works like a charm!

Thanks again

from grafana-client.

Excellent, thank you for reporting back, and for your suggestion in the first place. Cheers, Andreas.

from grafana-client.