404 Not Found and 500 Server error routes about isomorphic500 HOT 7 CLOSED

(follow this issue for the 404 status)

from isomorphic500.

For the 404 status:

import { find } from 'lodash';
const isNotFound = !!find(state.routes, { 'name': 'not-found' });
res.status(isNotFound ? 404 : 200).send(/* etc */);

from isomorphic500.

You don't need lodash :-p

let isNotFound = state.routes.some(route => route.name == 'not-found')

from isomorphic500.

Hi @gpbl,
I'm struggling with a similar situation as you described in remix-run/react-router#458 (comment)
I have a condition in ParentComponent#render() which renders NotFound component if resource hasn't been found.

In this case I can't spot it this way

Router.run(routes, req.url, (Handler, state) => {
       const html = React.renderToString //.....
       const isNotFound = _.find(state.routes, { 'name': 'not-found' });
       res.status(isNotFound ? 404 : 200).send(html);

because in state.routes I still have the route of ParentComponent and not 'not-found'.
Please suggest how to do that if you have figured it out. Thanks.

from isomorphic500.

I'm closing this because it becomes obsolete with the recent 'isomorphic500' release, based on flux. At the end I switched to the fluxible's router: it made easier to manage the error pages – mainly because it keeps all inside a "flux" flow.

@Snegostoop did you find a solution with the suggestions you got in the react-router comments?

from isomorphic500.

Up to this moment no, but I elaborated the question as much as I could so I hope we'll at least find out if it's even possible.
I'm also developing my app using flux, but I use another isomorphic-friendly library - flummox. Thanks for your suggestion of fluxible, I'll consider moving to it if this issue with react-router will not resolve.

from isomorphic500.

@Snegostoop I understand better now – you are in the case where a NotFound route may come from a 404 API response (e.g. /user/:id when id is a not existing user). In a flux application having a RouteStore, the idea (proposed by the fluxible team) is to execute an action that tell the store to display a 404 page. Honestly I don't know how this could work in a Router.run callback.

from isomorphic500.