Code Monkey home page Code Monkey logo

Comments (5)

gorhill avatar gorhill commented on May 29, 2024

Ok we need to stick to uMatrix here, I am having a hard time making sense of what is reported. uBlock is rather different than uMatrix internally, and it is confusing me more if you report both -- which have different behavior -- as a single issue.

I did see there was a problem with uMatrix not updating its badge. I think I got it fixed but I need to known exactly if this was the issue you reported, for now I can't figure exactly what you are reporting with uMatrix. Can you remove all references to uBlock so that I can clearly see what you are reporting with uMatrix?

To save time, regarding 6): uBlock may block more than what appears in the request log, because it is not uncommon for the same net requests to be fired more than once. So each time a specific net request is blocked it is counted as +1, even though it will be reported once in the request log. That would be impractical to repeat the same URL many times in the request log.

from umatrix.

Mikey1993 avatar Mikey1993 commented on May 29, 2024

Sure thing, I have removed the references to uBlock on the issue.
Is this more clear?

And about your reference to uBlock:
Then how about a counter in the statistics page to correct the misunderstanding that could cause someone to think that uBlock isn't reporting the right number of blocked URLs?
Though, the issue that was reported here with uBlock is that the statistics that are being reported after going back on Github are totally wrong (not changing accordingly to the page shifting), and not about the number of accounted net requests on a given page in the statistics tab.

from umatrix.

Mikey1993 avatar Mikey1993 commented on May 29, 2024

I am also able to reproduce this issue on GitLab:
https://gitlab.com/fdroid/fdroidclient

When clicking on one of the top bar pages and going back with the mouse button.

from umatrix.

gorhill avatar gorhill commented on May 29, 2024

Ok, so at 5)-6) this is what I fixed: the badge wasn't updated. This was a case of the URL changing in the address bar, but no document load occurring.

Re uBlock: it works quite differently than uMatrix. In uBlock, the stats are not reset when the URL in the address bar changes, they are reset when a new document is (re)loaded. Resetting uBlock stats whenever the URL changed was really annoying in some heavy cases of pages which change incrementally. Best example is Google Maps.

Currently uMatrix is completely URL-based, so whenever the URL changes, a new internal data structure to hold matrix stats is created. This is annoying on site such as Google Maps. I think I may need to revise that to be more like uBlock, i.e. reusing internal data structure when the URL is updated without the main doc in the page being reloaded.

from umatrix.

gorhill avatar gorhill commented on May 29, 2024

Oops, the second fix hides the first fix.

from umatrix.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.