Underscore in domain name breaks whitelist editor about ublock HOT 4 CLOSED

Tested on Win 10, Chrome 68 and Firefox 59.0.2, uBlock Origin 1.15.24.
Part of the problem can be reproduced on Ubuntu 17.10.

The fix might not be straight forward, Windows happily accept http://a--t--.test.jspenguin.com/ as valid address but Ubuntu doesn't like it. Note that http://---.test.jspenguin.com/ is not accepted in Windows.

Maybe just lift the restriction and accept anything that looks remotely reasonable as valid?

µBlock.reWhitelistBadHostname = /[^a-z0-9.\-_\[\]:]/;
µBlock.reWhitelistHostnameExtractor = /([a-z0-9.\-_\[\]]+)(?::[\d*]+)?\/(?:[^\x00-\x20\/]|$)[^\x00-\x20]*$/;

from ublock.

Maybe just lift the restriction and accept anything that looks remotely reasonable as valid?

Yes, as long as a hostname can be extracted -- valid or not.

from ublock.

Well since you are almost there, can you submit a pull request with the modified regexes?

from ublock.

Fixed with PR #3718.

from ublock.