Commit or ignore vendor/ about godownloader HOT 5 CLOSED

I prefer it the other way around 😉
When you commit them the project stays installable via go get. Also I like being in as much control as possible about the code that goes into a project. If you have to commit to the dependencies you think twice if it's worth it to include yet another library. And when they are part of the repo, there is even a chance that you might check some day what the code in vendor/ actually does.
I still think dep is super important because you need to keep the dependencies up to date.

But that's just my personal preference. In the end it doesn't matter much for me.

from godownloader.

I also prefer committing the vendor dir...for what @jorinvo said but also for other reasons too.

It makes builds and travis faster, and less brittle. GitHub and / or the network sometimes has problems, or even sometimes entire repos get moved. If vendor is checked in, I just eliminated a whole bunch of failure cases.

That said, I'm happy to follow the convention of goreleaser here.

from godownloader.

My 2 cents:

I always ignore them.

IMHO The purpose of using a dep manager is for the dep manager to manages deps :)

from godownloader.

@client9 especially with (currently) only GoReleaser as dependency a lot of the reasons for committing are weaker since both projects kinda belong together anyways.
Would also agree with you that for the case of this project it's probably a good decision to just add it to the .gitignore file 👍

from godownloader.

completely agree @jorinvo I'll add the .gitignore

from godownloader.