Comments (5)
I prefer it the other way around 😉
When you commit them the project stays installable via go get
. Also I like being in as much control as possible about the code that goes into a project. If you have to commit to the dependencies you think twice if it's worth it to include yet another library. And when they are part of the repo, there is even a chance that you might check some day what the code in vendor/
actually does.
I still think dep
is super important because you need to keep the dependencies up to date.
But that's just my personal preference. In the end it doesn't matter much for me.
from godownloader.
I also prefer committing the vendor dir...for what @jorinvo said but also for other reasons too.
It makes builds and travis faster, and less brittle. GitHub and / or the network sometimes has problems, or even sometimes entire repos get moved. If vendor is checked in, I just eliminated a whole bunch of failure cases.
That said, I'm happy to follow the convention of goreleaser here.
from godownloader.
My 2 cents:
I always ignore them.
IMHO The purpose of using a dep manager is for the dep manager to manages deps :)
from godownloader.
@client9 especially with (currently) only GoReleaser as dependency a lot of the reasons for committing are weaker since both projects kinda belong together anyways.
Would also agree with you that for the case of this project it's probably a good decision to just add it to the .gitignore
file 👍
from godownloader.
completely agree @jorinvo I'll add the .gitignore
from godownloader.
Related Issues (20)
- Installs failing because $BINARY not defined
- Improve CI tests HOT 3
- I broke Travis with ARM format? HOT 4
- Any plans to add godownloader binaries in the releases? HOT 2
- l
- cannot build from source cause git.apache.org/thrift.git has gone away HOT 5
- Invalid pseudo-version
- Call for Maintainers HOT 34
- Dependabot can't parse your go.mod HOT 1
- Error: "replace" function not defined HOT 1
- Dependabot can't parse your go.mod HOT 1
- Dependabot can't parse your go.mod
- Dependabot can't resolve your Go dependency files
- Can't commit due to an error in lint in git hooks HOT 1
- Error when upgrading goreleaser version HOT 1
- Fail tree repository HOT 1
- Dependabot can't resolve your Go dependency files
- Dependabot can't resolve your Go dependency files HOT 1
- FR: Add PowerShell downloader HOT 1
- FYI: this repo is deprecated
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from godownloader.